Subject: Re: [PATCH net-next 12/13] ice: implement low latency PHY timer updates

From: Jakub Kicinski <[email-masked]>
Date: Thu, 9 Jan 2025 18:18:23 -0800

On Wed,  8 Jan 2025 14:17:49 -0800 Tony Nguyen wrote:
> +	spin_lock_irqsave(&params->atqbal_wq.lock, flags);
> +
> +	/* Wait for any pending in-progress low latency interrupt */
> +	err = wait_event_interruptible_locked_irq(params->atqbal_wq,

Don't you need an irqsave() flavor of
wait_event_interruptible_locked_irq() for this to work correctly? 🤔️
-- 
pw-bot: cr