Subject: Re: [PATCH net-next 08/13] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810

From: Jakub Kicinski <[email-masked]>
Date: Thu, 9 Jan 2025 18:21:48 -0800

On Wed,  8 Jan 2025 14:17:45 -0800 Tony Nguyen wrote:
> --- a/drivers/net/ethernet/intel/ice/ice_osdep.h
> +++ b/drivers/net/ethernet/intel/ice/ice_osdep.h
> @@ -26,6 +26,9 @@
>  
>  #define rd32_poll_timeout(a, addr, val, cond, delay_us, timeout_us) \
>  	read_poll_timeout(rd32, val, cond, delay_us, timeout_us, false, a, addr)
> +#define rd32_poll_timeout_atomic(a, addr, val, cond, delay_us, timeout_us) \
> +	read_poll_timeout_atomic(rd32, val, cond, delay_us, timeout_us, false, \
> +				 a, addr)

Could you deprecate the use of the osdep header? At the very least don't
add new stuff here. Back in the day "no OS abstraction layers" was 
a pretty hard and fast rule. I don't hear it as much these days, but 
I think it's still valid since this just obfuscates the code for all
readers outside your team.