From: Simon Horman <horms@kernel•org>
To: Divya Koppera <divya.koppera@microchip•com>
Cc: andrew@lunn•ch, arun.ramadoss@microchip•com,
UNGLinuxDriver@microchip•com, hkallweit1@gmail•com,
linux@armlinux•org.uk, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, richardcochran@gmail•com,
vadim.fedorenko@linux•dev
Subject: Re: [PATCH net] net: phy: Kconfig: Fix error related to undefined reference
Date: Thu, 9 Jan 2025 20:02:47 +0000 [thread overview]
Message-ID: <20250109200247.GR7706@kernel.org> (raw)
In-Reply-To: <20250109121432.12664-1-divya.koppera@microchip.com>
On Thu, Jan 09, 2025 at 05:44:32PM +0530, Divya Koppera wrote:
> When microchip_t1_phy is built in and phyptp is module
> facing undefined reference issue. This get fixed when
> microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202501090604.YEoJXCXi-lkp@intel.com
> Fixes: fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys")
> Signed-off-by: Divya Koppera <divya.koppera@microchip•com>
Hi Divya,
I think that this patch should be targeted at net-next, where
the problem seems to manifest, rather than net where it does not.
Likewise, this patch applies to net-next, but not net.
Also, I think the prefix for the patch should be "net: phy: microchip_t1".
And perhaps the following subject is a bit more descriptive.
[PATCH net-next] net: phy: microchip_t1: depend on PTP_1588_CLOCK_OPTIONAL
As for the code change itself, it looks good to me.
Reviewed-by: Simon Horman <horms@kernel•org>
Tested-by: Simon Horman <horms@kernel•org> # build-tested
--
pw-bot: changes-requested
prev parent reply other threads:[~2025-01-09 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 12:14 [PATCH net] net: phy: Kconfig: Fix error related to undefined reference Divya Koppera
2025-01-09 20:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109200247.GR7706@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arun.ramadoss@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=divya.koppera@microchip$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox