Subject: Re: [PATCH net] net: phy: Kconfig: Fix error related to undefined reference

From: Simon Horman <[email-masked]>
Date: Thu, 9 Jan 2025 20:02:47 +0000

On Thu, Jan 09, 2025 at 05:44:32PM +0530, Divya Koppera wrote:
> When microchip_t1_phy is built in and phyptp is module
> facing undefined reference issue. This get fixed when
> microchip_t1_phy made dependent on PTP_1588_CLOCK_OPTIONAL.
> 
> Reported-by: kernel test robot <[email-masked]>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/[email-masked]
> Fixes: fa51199c5f34 ("net: phy: microchip_rds_ptp : Add rds ptp library for Microchip phys")
> Signed-off-by: Divya Koppera <[email-masked]>

Hi Divya,

I think that this patch should be targeted at net-next, where
the problem seems to manifest, rather than net where it does not.
Likewise, this patch applies to net-next, but not net.

Also, I think the prefix for the patch should be "net: phy: microchip_t1".
And perhaps the following subject is a bit more descriptive.

	[PATCH net-next] net: phy: microchip_t1: depend on PTP_1588_CLOCK_OPTIONAL

As for the code change itself, it looks good to me.

Reviewed-by: Simon Horman <[email-masked]>
Tested-by: Simon Horman <[email-masked]> # build-tested

-- 
pw-bot: changes-requested