Subject: Re: [PATCH net-next 08/13] ice: use rd32_poll_timeout_atomic in ice_read_phy_tstamp_ll_e810

From: Jakub Kicinski <[email-masked]>
Date: Mon, 13 Jan 2025 10:33:06 -0800

On Mon, 13 Jan 2025 10:18:05 -0800 Jacob Keller wrote:
> > Ack, and short hands make sense. But both rd32_poll_timeout_atomic and
> > the exiting rd32_poll_timeout have a single user.  
> 
> The intention with introducing these is to help make it easier for other
> developers to use poll_timeout and friends throughout the driver.
> There's only one user now, but my intention had been that we'd see more
> as it becomes more known and is easier to use.

IMHO the ease of use gain is equal to the loss of generality (driver
local flavor of a common function will make contributing outside the
driver harder).

To be clear it's not a blocker, I'm only complaining because there was
a bug in the other patch.