From: Jakub Kicinski <kuba@kernel•org>
To: Potin Lai <potin.lai.pt@gmail•com>
Cc: "Paul Fertser" <fercerpav@gmail•com>,
"Potin Lai (賴柏廷 )" <Potin.Lai@quantatw•com>,
"Samuel Mendoza-Jonas" <sam@mendozajonas•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Ivan Mikhaylov" <fr0st61te@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"stable@vger•kernel.org" <stable@vger•kernel.org>,
"Cosmo Chou ( 周楷培)" <Cosmo.Chou@quantatw•com>,
"patrick@stwcx•xyz" <patrick@stwcx•xyz>,
"Cosmo Chou" <chou.cosmo@gmail•com>
Subject: Re: 回覆: [External] Re: [PATCH] net/ncsi: fix locking in Get MAC Address handling
Date: Mon, 13 Jan 2025 13:19:34 -0800 [thread overview]
Message-ID: <20250113131934.5566be67@kernel.org> (raw)
In-Reply-To: <CAGfYmwVECrisZMhWAddmnczcLqFfNZ2boNAD5=p2HHuOhLy75w@mail.gmail.com>
On Sat, 11 Jan 2025 19:12:51 +0800 Potin Lai wrote:
> > > Thanks for the new patch.
> > > I am currently tied up with other tasks, but I’ll make sure to test
> > > it as soon as possible and share the results with you.
> >
> > Understood, would you be able to test it by January 13th?
> > Depending on how long we need to wait we may be better off
> > applying the patch already or waiting with committing..
>
> Hi Jakub & Paul,
>
> I had a test yesterday, the patch is working and the kernel panic does
> not happen any more, but we notice sometimes the config_apply_mac
> state runs before the gma command is handled.
>
> Cosmo helped me to find a potential state handling issue, and I
> submitted the v2 version.
> Please kindly have a look at v2 version with the link below.
> v2: https://lore.kernel.org/all/20250111-fix-ncsi-mac-v2-0-838e0a1a233a@gmail.com/
Is there any reason why you reposted Paul's patch?
Patch 2 looks like a fix for a separate issue (but for the same
use case), am I wrong?
Also one thing you have not done is to provide the Tested-by: tag
on Paul's patch :)
next prev parent reply other threads:[~2025-01-13 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 19:23 [PATCH net v2] Revert "net/ncsi: change from ndo_set_mac_address to dev_set_mac_address" Jakub Kicinski
2025-01-08 20:23 ` Paul Fertser
2025-01-08 21:44 ` Jakub Kicinski
2025-01-08 21:48 ` Ivan Mikhaylov
2025-01-09 3:16 ` Jakub Kicinski
2025-01-09 14:50 ` [PATCH] net/ncsi: fix locking in Get MAC Address handling Paul Fertser
2025-01-09 16:33 ` Jakub Kicinski
[not found] ` <TYSPR04MB7868EA6003981521C1B2FDAB8E1C2@TYSPR04MB7868.apcprd04.prod.outlook.com>
2025-01-11 2:18 ` 回覆: [External] " Jakub Kicinski
2025-01-11 11:12 ` Potin Lai
2025-01-13 21:19 ` Jakub Kicinski [this message]
2025-01-14 1:56 ` Potin Lai
2025-01-14 3:04 ` Jakub Kicinski
2025-01-14 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250113131934.5566be67@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Cosmo.Chou@quantatw$(echo .)com \
--cc=Potin.Lai@quantatw$(echo .)com \
--cc=chou.cosmo@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fercerpav@gmail$(echo .)com \
--cc=fr0st61te@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=patrick@stwcx$(echo .)xyz \
--cc=potin.lai.pt@gmail$(echo .)com \
--cc=sam@mendozajonas$(echo .)com \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox