Subject: Re: [PATCH net v2] net: appletalk: Drop aarp_send_probe_phase1()

From: Jakub Kicinski <[email-masked]>
Date: Wed, 15 Jan 2025 14:06:29 -0800

On Mon, 13 Jan 2025 09:44:51 +0000 [email-masked] wrote:
>  void aarp_probe_network(struct atalk_iface *atif)
>  {
> -	if (atif->dev->type == ARPHRD_LOCALTLK ||
> -	    atif->dev->type == ARPHRD_PPP)
> -		aarp_send_probe_phase1(atif);
> -	else {
> +	if (atif->dev->type != ARPHRD_LOCALTLK &&
> +	    atif->dev->type != ARPHRD_PPP) {
>  		unsigned int count;

You assert this is our only option, so why leave the if () around 
at all?

nit: subject prefix should be "PATCH net-next v2"
-- 
pw-bot: cr