Subject: Re: [PATCH net-next v10 11/22] net: page_pool: add memory provider helpers

From: Jakub Kicinski <[email-masked]>
Date: Wed, 15 Jan 2025 16:49:34 -0800

On Wed,  8 Jan 2025 14:06:32 -0800 David Wei wrote:
> +void net_mp_niov_set_page_pool(struct page_pool *pool, struct net_iov *niov);
> +void net_mp_niov_clear_page_pool(struct net_iov *niov);
> +
> +/*

nit: if you meant this to be a kdoc you're missing a * here.

> + * net_mp_netmem_place_in_cache() - give a netmem to a page pool
> + * @pool:      the page pool to place the netmem into
> + * @netmem:    netmem to give
> + *
> + * Push an accounted netmem into the page pool's allocation cache. The caller
> + * must ensure that there is space in the cache. It should only be called off
> + * the mp_ops->alloc_netmems() path.
> + */
> +static inline void net_mp_netmem_place_in_cache(struct page_pool *pool,
> +						netmem_ref netmem)
> +{
> +	pool->alloc.cache[pool->alloc.count++] = netmem;
> +}