From: Jakub Kicinski <kuba@kernel•org>
To: Ahmed Zaki <ahmed.zaki@intel•com>
Cc: netdev@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
andrew+netdev@lunn•ch, edumazet@google•com, horms@kernel•org,
pabeni@redhat•com, davem@davemloft•net,
michael.chan@broadcom•com, tariqt@nvidia•com,
anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
jdamato@fastly•com, shayd@nvidia•com, akpm@linux-foundation•org,
shayagr@amazon•com, kalesh-anakkur.purayil@broadcom•com,
David Arinzon <darinzon@amazon•com>
Subject: Re: [PATCH net-next v6 1/5] net: move ARFS rmap management to core
Date: Mon, 20 Jan 2025 16:59:27 -0800 [thread overview]
Message-ID: <20250120165927.45ef723b@kernel.org> (raw)
In-Reply-To: <20250118003335.155379-2-ahmed.zaki@intel.com>
On Fri, 17 Jan 2025 17:33:31 -0700 Ahmed Zaki wrote:
> +#ifdef CONFIG_RFS_ACCEL
> +static void
> +netif_irq_cpu_rmap_notify(struct irq_affinity_notify *notify,
> + const cpumask_t *mask)
> +{
> + struct napi_struct *napi =
> + container_of(notify, struct napi_struct, notify);
> + struct cpu_rmap *rmap = napi->dev->rx_cpu_rmap;
> + int err;
> +
> + if (napi->dev->rx_cpu_rmap_auto) {
Can this ever not be true?
> + err = cpu_rmap_update(rmap, napi->napi_rmap_idx, mask);
> + if (err)
> + pr_warn("%s: RMAP update failed (%d)\n",
> + __func__, err);
netdev_warn(napi->dev, "...) ?
> + }
> +}
> +
> +static void netif_napi_affinity_release(struct kref *ref)
> +{
> + struct napi_struct *napi =
> + container_of(ref, struct napi_struct, notify.kref);
> + struct cpu_rmap *rmap = napi->dev->rx_cpu_rmap;
> +
> + if (!napi->dev->rx_cpu_rmap_auto)
Similar question, can it possibly be false without driver bugs?
I think you disable rmap completely if we can't add a single IRQ,
that may be too drastic. Better miss one IRQ than the whole rmap, no?
> + return;
> + rmap->obj[napi->napi_rmap_idx] = NULL;
> + napi->napi_rmap_idx = -1;
Why do we modify NAPI here? Shouldn't caller be responsible for this?
> + cpu_rmap_put(rmap);
> +}
> +
> +static int napi_irq_cpu_rmap_add(struct napi_struct *napi, int irq)
> +{
> + struct cpu_rmap *rmap = napi->dev->rx_cpu_rmap;
> + int rc;
> +
> + if (!rmap)
Should never happen, I'd ignore this and let the kernel crash below.
> + return -EINVAL;
> +
> + napi->notify.notify = netif_irq_cpu_rmap_notify;
> + napi->notify.release = netif_napi_affinity_release;
> + cpu_rmap_get(rmap);
> + rc = cpu_rmap_add(rmap, napi);
> + if (rc < 0)
> + goto err_add;
> +
> + napi->napi_rmap_idx = rc;
> + rc = irq_set_affinity_notifier(irq, &napi->notify);
> + if (rc)
> + goto err_set;
> +
> + return 0;
> +
> +err_set:
> + rmap->obj[napi->napi_rmap_idx] = NULL;
> + napi->napi_rmap_idx = -1;
> +err_add:
> + cpu_rmap_put(rmap);
> + return rc;
> +}
next prev parent reply other threads:[~2025-01-21 0:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 0:33 [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 1/5] net: move ARFS rmap management to core Ahmed Zaki
2025-01-21 0:59 ` Jakub Kicinski [this message]
2025-01-21 14:52 ` Ahmed Zaki
2025-01-23 19:28 ` Joe Damato
2025-01-23 20:13 ` Ahmed Zaki
2025-01-23 20:20 ` Joe Damato
2025-01-18 0:33 ` [PATCH net-next v6 2/5] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-01-21 1:03 ` Jakub Kicinski
2025-01-23 20:18 ` Joe Damato
2025-02-03 21:32 ` Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 3/5] bnxt: use napi's irq affinity Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 4/5] ice: " Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 5/5] idpf: " Ahmed Zaki
2025-01-21 1:03 ` [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Jakub Kicinski
2025-01-21 14:54 ` Ahmed Zaki
2025-01-23 20:27 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120165927.45ef723b@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=darinzon@amazon$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jdamato@fastly$(echo .)com \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=shayd@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox