From: Furong Xu <0x1207@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: Ido Schimmel <idosch@idosch•org>,
Brad Griffis <bgriffis@nvidia•com>,
Jon Hunter <jonathanh@nvidia•com>,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org,
Alexander Lobakin <aleksander.lobakin@intel•com>,
Joe Damato <jdamato@fastly•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
xfr@outlook•com,
"linux-tegra@vger•kernel.org" <linux-tegra@vger•kernel.org>
Subject: Re: [PATCH net-next v3 1/4] net: stmmac: Switch to zero-copy in non-XDP RX path
Date: Sun, 26 Jan 2025 10:39:52 +0800 [thread overview]
Message-ID: <20250126103952.00005556@gmail.com> (raw)
In-Reply-To: <09442385-573c-4756-8c30-296631bc6272@lunn.ch>
On Sat, 25 Jan 2025 20:08:12 +0100, Andrew Lunn <andrew@lunn•ch> wrote:
> > It is recommended to disable the "SPH feature" by default unless
> > some certain cases depend on it. Like Ido said, two large buffers
> > being allocated from the same page pool for each packet, this is a
> > huge waste of memory, and brings performance drops for most of
> > general cases.
>
> I don't know this driver, but it looks like SPH is required for
> NETIF_F_GRO? Can you add this flag to hw_features, but not
> wanted_features and leave SPH disabled until ethtool is used to enable
> GRO?
SPH has its own ethtool command, stmmac driver does not implement yet.
see:
https://patchwork.kernel.org/project/netdevbpf/cover/20250114142852.3364986-1-ap420073@gmail.com/
> Are there other use cases where SPH is needed?
https://patchwork.kernel.org/project/netdevbpf/cover/20240910171458.219195-1-almasrymina@google.com/
https://patchwork.kernel.org/project/netdevbpf/cover/20250116231704.2402455-1-dw@davidwei.uk/
The stmmac driver does not support both of them, but it will someday :)
next prev parent reply other threads:[~2025-01-26 2:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 3:27 [PATCH net-next v3 0/4] net: stmmac: RX performance improvement Furong Xu
2025-01-15 3:27 ` [PATCH net-next v3 1/4] net: stmmac: Switch to zero-copy in non-XDP RX path Furong Xu
2025-01-15 16:58 ` Larysa Zaremba
2025-01-16 2:05 ` Yanteng Si
2025-01-23 14:06 ` Jon Hunter
2025-01-23 16:35 ` Furong Xu
2025-01-23 19:53 ` Brad Griffis
2025-01-23 21:48 ` Andrew Lunn
2025-01-24 2:42 ` Furong Xu
2025-01-24 13:15 ` Thierry Reding
2025-01-28 20:04 ` Lucas Stach
2025-01-25 10:20 ` Ido Schimmel
2025-01-25 14:43 ` Furong Xu
2025-01-26 8:41 ` Ido Schimmel
2025-01-26 10:37 ` Furong Xu
2025-01-26 11:35 ` Ido Schimmel
2025-01-26 12:56 ` Furong Xu
2025-01-25 15:03 ` Furong Xu
2025-01-25 19:08 ` Andrew Lunn
2025-01-26 2:39 ` Furong Xu [this message]
2025-01-27 13:28 ` Thierry Reding
2025-01-29 14:51 ` Jon Hunter
2025-02-07 9:07 ` Furong Xu
2025-02-07 13:42 ` Jon Hunter
2025-01-24 1:53 ` Furong Xu
2025-01-24 15:14 ` Andrew Lunn
2025-01-15 3:27 ` [PATCH net-next v3 2/4] net: stmmac: Set page_pool_params.max_len to a precise size Furong Xu
2025-01-15 10:07 ` Yanteng Si
2025-01-15 3:27 ` [PATCH net-next v3 3/4] net: stmmac: Optimize cache prefetch in RX path Furong Xu
2025-01-15 16:24 ` Yanteng Si
2025-01-15 3:27 ` [PATCH net-next v3 4/4] net: stmmac: Convert prefetch() to net_prefetch() for received frames Furong Xu
2025-01-15 16:33 ` Yanteng Si
2025-01-15 16:35 ` Larysa Zaremba
2025-01-15 17:35 ` Joe Damato
2025-01-16 11:40 ` [PATCH net-next v3 0/4] net: stmmac: RX performance improvement patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250126103952.00005556@gmail.com \
--to=0x1207@gmail$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=bgriffis@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@idosch$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xfr@outlook$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox