From: Simon Horman <horms@kernel•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: netdev@vger•kernel.org, jhs@mojatatu•com, jiri@resnulli•us,
quanglex97@gmail•com, mincho@theori•io,
Cong Wang <cong.wang@bytedance•com>
Subject: Re: [Patch net 2/4] Add test case to check for pfifo_tail_enqueue() behaviour when limit == 0
Date: Mon, 27 Jan 2025 17:54:53 +0000 [thread overview]
Message-ID: <20250127175453.GG5024@kernel.org> (raw)
In-Reply-To: <Z5Wxh/oUF2meTEBS@pop-os.localdomain>
On Sat, Jan 25, 2025 at 07:52:39PM -0800, Cong Wang wrote:
> On Sat, Jan 25, 2025 at 07:20:42PM -0800, Cong Wang wrote:
> > On Fri, Jan 24, 2025 at 11:37:43AM +0000, Simon Horman wrote:
> > > On Thu, Jan 23, 2025 at 10:07:38PM -0800, Cong Wang wrote:
> > > > From: Quang Le <quanglex97@gmail•com>
> > > >
> > > > When limit == 0, pfifo_tail_enqueue() must drop new packet and
> > > > increase dropped packets count of scheduler.
> > > >
> > > > Signed-off-by: Quang Le <quanglex97@gmail•com>
> > > > Signed-off-by: Cong Wang <cong.wang@bytedance•com>
> > >
> > > Hi Cong, all,
> > >
> > > This test is reporting "not ok" in the Netdev CI.
> > >
> > > # not ok 577 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0
> > > # Could not match regex pattern. Verify command output:
> > > # qdisc pfifo_head_drop 1: root refcnt 2 limit 0p
> > > # Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
> > > # backlog 0b 0p requeues 0
> >
> > Oops... It worked on my side, let me take a look.
> >
>
> I ran it again for multiple times, it still worked for me:
>
> 1..16
> ok 1 a519 - Add bfifo qdisc with system default parameters on egress
> ok 2 585c - Add pfifo qdisc with system default parameters on egress
> ok 3 a86e - Add bfifo qdisc with system default parameters on egress with handle of maximum value
> ok 4 9ac8 - Add bfifo qdisc on egress with queue size of 3000 bytes
> ok 5 f4e6 - Add pfifo qdisc on egress with queue size of 3000 packets
> ok 6 b1b1 - Add bfifo qdisc with system default parameters on egress with invalid handle exceeding maximum value
> ok 7 8d5e - Add bfifo qdisc on egress with unsupported argument
> ok 8 7787 - Add pfifo qdisc on egress with unsupported argument
> ok 9 c4b6 - Replace bfifo qdisc on egress with new queue size
> ok 10 3df6 - Replace pfifo qdisc on egress with new queue size
> ok 11 7a67 - Add bfifo qdisc on egress with queue size in invalid format
> ok 12 1298 - Add duplicate bfifo qdisc on egress
> ok 13 45a0 - Delete nonexistent bfifo qdisc
> ok 14 972b - Add prio qdisc on egress with invalid format for handles
> ok 15 4d39 - Delete bfifo qdisc twice
> ok 16 d774 - Check pfifo_head_drop qdisc enqueue behaviour when limit == 0
>
> Could you provide a link for me to check?
I'll send you some links off-list.
>
> Just in case, please make sure patch 1/4 is applied before this test,
> otherwise packets would not be dropped.
Yes, I am pretty sure that is the case.
>
> Meanwhile, I do need to update this patch anyway, because it hardcoded
> dummy2...
>
> Thanks.
>
next prev parent reply other threads:[~2025-01-27 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 6:07 [Patch net 0/4] net_sched: two security bug fixes and test cases Cong Wang
2025-01-24 6:07 ` [Patch net 1/4] pfifo_tail_enqueue: Drop new packet when sch->limit == 0 Cong Wang
2025-01-30 11:17 ` Jamal Hadi Salim
2025-01-31 21:53 ` Cong Wang
2025-01-24 6:07 ` [Patch net 2/4] Add test case to check for pfifo_tail_enqueue() behaviour when limit " Cong Wang
2025-01-24 11:37 ` Simon Horman
2025-01-26 3:20 ` Cong Wang
2025-01-26 3:52 ` Cong Wang
2025-01-27 17:54 ` Simon Horman [this message]
2025-01-24 6:07 ` [Patch net 3/4] netem: update sch->q.qlen before qdisc_tree_reduce_backlog() Cong Wang
2025-01-24 6:07 ` [Patch net 4/4] selftests/tc-testing: add tests for qdisc_tree_reduce_backlog Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127175453.GG5024@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=cong.wang@bytedance$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=mincho@theori$(echo .)io \
--cc=netdev@vger$(echo .)kernel.org \
--cc=quanglex97@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox