From: Jakub Kicinski <kuba@kernel•org>
To: Anna Emese Nyiri <annaemesenyiri@gmail•com>
Cc: netdev@vger•kernel.org, fejes@inf•elte.hu, edumazet@google•com,
pabeni@redhat•com, willemb@google•com, idosch@idosch•org,
davem@davemloft•net, horms@kernel•org, shuah@kernel•org,
linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net-next 1/1] selftests: net: Add support for testing SO_RCVMARK and SO_RCVPRIORITY
Date: Wed, 29 Jan 2025 12:05:26 -0800 [thread overview]
Message-ID: <20250129120526.7ba0958b@kernel.org> (raw)
In-Reply-To: <20250129143601.16035-2-annaemesenyiri@gmail.com>
On Wed, 29 Jan 2025 15:36:01 +0100 Anna Emese Nyiri wrote:
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 73ee88d6b043..98f05473e672 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -33,6 +33,7 @@ TEST_PROGS += gro.sh
> TEST_PROGS += gre_gso.sh
> TEST_PROGS += cmsg_so_mark.sh
> TEST_PROGS += cmsg_so_priority.sh
> +TEST_PROGS += test_so_rcv.sh
You need to add the C part to the TEST_GEN_PROGS, otherwise it won't
get built. We're seeing:
./test_so_rcv.sh: line 25: ./so_rcv_listener: No such file or directory
in the CI.
> + memset(&recv_addr, 0, sizeof(recv_addr));
> + recv_addr.sin_family = AF_INET;
> + recv_addr.sin_port = htons(atoi(opt.service));
> +
> + if (inet_pton(AF_INET, opt.host, &recv_addr.sin_addr) <= 0) {
> + perror("Invalid address");
> + ret_value = -errno;
> + goto cleanup;
> + }
Any reason not to use getaddrinfo() ?
Otherwise LGTM, thanks for following up!
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-29 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 14:36 [PATCH net-next 0/1] selftests: net: Add support for testing SO_RCVMARK and SO_RCVPRIORITY Anna Emese Nyiri
2025-01-29 14:36 ` [PATCH net-next 1/1] " Anna Emese Nyiri
2025-01-29 20:05 ` Jakub Kicinski [this message]
2025-01-30 13:27 ` Anna Nyiri
2025-01-30 15:06 ` Willem de Bruijn
2025-01-30 15:15 ` Willem de Bruijn
2025-02-02 16:00 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129120526.7ba0958b@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=annaemesenyiri@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fejes@inf$(echo .)elte.hu \
--cc=horms@kernel$(echo .)org \
--cc=idosch@idosch$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox