From: Jakub Kicinski <kuba@kernel•org>
To: Kory Maincent <kory.maincent@bootlin•com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Donald Hunter <donald.hunter@gmail•com>,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH net 2/3] net: ethtool: tsconfig: Fix ts filters and types enums size check
Date: Thu, 30 Jan 2025 08:42:27 -0800 [thread overview]
Message-ID: <20250130084227.51e29094@kernel.org> (raw)
In-Reply-To: <20250130102451.46a4b247@kmaincent-XPS-13-7390>
On Thu, 30 Jan 2025 10:24:51 +0100 Kory Maincent wrote:
> > This is just a code cleanup, the constants are way smaller than 32
> > today. The assert being too restrictive makes no functional difference.
>
> That's right, it was mainly for consistency with the other assert. And to avoid
> possible future mistake but indeed reaching 32 bit is not expected soon. Should
> I remove the patch as it is not a functional issue?
Yes, drop it please and repost after net-next re-opens.
next prev parent reply other threads:[~2025-01-30 16:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 15:35 [PATCH net 0/3] net: ethtool: timestamping: Fix small issues in the new uAPI Kory Maincent
2025-01-28 15:35 ` [PATCH net 1/3] MAINTAINERS: Add myself as maintainer for socket timestamping and expand file list Kory Maincent
2025-01-30 0:39 ` Jakub Kicinski
2025-01-30 9:18 ` Kory Maincent
2025-01-30 16:31 ` Jakub Kicinski
2025-01-30 16:56 ` Kory Maincent
2025-01-28 15:35 ` [PATCH net 2/3] net: ethtool: tsconfig: Fix ts filters and types enums size check Kory Maincent
2025-01-30 0:45 ` Jakub Kicinski
2025-01-30 9:24 ` Kory Maincent
2025-01-30 16:42 ` Jakub Kicinski [this message]
2025-01-28 15:35 ` [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of hwtstamp flags Kory Maincent
2025-01-30 0:49 ` Jakub Kicinski
2025-01-30 9:27 ` Kory Maincent
2025-01-30 16:43 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130084227.51e29094@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox