From: Simon Horman <horms@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, andrew+netdev@lunn•ch,
Justin Iurman <justin.iurman@uliege•be>,
dsahern@kernel•org
Subject: Re: [PATCH net v2 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels
Date: Thu, 30 Jan 2025 10:23:24 +0000 [thread overview]
Message-ID: <20250130102324.GC113107@kernel.org> (raw)
In-Reply-To: <20250130031519.2716843-1-kuba@kernel.org>
On Wed, Jan 29, 2025 at 07:15:18PM -0800, Jakub Kicinski wrote:
> dst_cache_get() gives us a reference, we need to release it.
>
> Discovered by the ioam6.sh test, kmemleak was recently fixed
> to catch per-cpu memory leaks.
>
> Fixes: 985ec6f5e623 ("net: ipv6: rpl_iptunnel: mitigate 2-realloc issue")
> Fixes: 40475b63761a ("net: ipv6: seg6_iptunnel: mitigate 2-realloc issue")
> Fixes: dce525185bc9 ("net: ipv6: ioam6_iptunnel: mitigate 2-realloc issue")
> Reviewed-by: Justin Iurman <justin.iurman@uliege•be>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2025-01-30 10:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 3:15 [PATCH net v2 1/2] net: ipv6: fix dst refleaks in rpl, seg6 and ioam6 lwtunnels Jakub Kicinski
2025-01-30 3:15 ` [PATCH net v2 2/2] net: ipv6: fix dst ref loops " Jakub Kicinski
2025-01-30 10:28 ` Simon Horman
2025-01-30 13:41 ` Justin Iurman
2025-01-30 14:56 ` Jakub Kicinski
2025-01-30 15:35 ` Simon Horman
2025-01-30 11:34 ` Paolo Abeni
2025-01-30 13:52 ` Justin Iurman
2025-01-30 14:55 ` Jakub Kicinski
2025-01-30 15:12 ` Justin Iurman
2025-01-30 16:53 ` Jakub Kicinski
2025-02-01 13:52 ` Justin Iurman
2025-02-02 0:56 ` Jakub Kicinski
2025-01-30 10:23 ` Simon Horman [this message]
2025-02-02 1:00 ` [PATCH net v2 1/2] net: ipv6: fix dst refleaks " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250130102324.GC113107@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=justin.iurman@uliege$(echo .)be \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox