From: Simon Horman <horms@kernel•org>
To: Mina Almasry <almasrymina@google•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-doc@vger•kernel.org, kvm@vger•kernel.org,
virtualization@lists•linux.dev, linux-kselftest@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Donald Hunter" <donald.hunter@gmail•com>,
"Jonathan Corbet" <corbet@lwn•net>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"David Ahern" <dsahern@kernel•org>,
"Stefan Hajnoczi" <stefanha@redhat•com>,
"Stefano Garzarella" <sgarzare@redhat•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Shuah Khan" <shuah@kernel•org>,
sdf@fomichev•me, asml.silence@gmail•com, dw@davidwei•uk,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Victor Nogueira" <victor@mojatatu•com>,
"Pedro Tammela" <pctammela@mojatatu•com>
Subject: Re: [PATCH RFC net-next v2 4/6] net: devmem: TCP tx netlink api
Date: Fri, 31 Jan 2025 08:29:28 +0000 [thread overview]
Message-ID: <20250131082928.GA24105@kernel.org> (raw)
In-Reply-To: <20250130211539.428952-5-almasrymina@google.com>
On Thu, Jan 30, 2025 at 09:15:37PM +0000, Mina Almasry wrote:
> From: Stanislav Fomichev <sdf@fomichev•me>
>
> Add bind-tx netlink call to attach dmabuf for TX; queue is not
> required, only ifindex and dmabuf fd for attachment.
>
> Signed-off-by: Stanislav Fomichev <sdf@fomichev•me>
> Signed-off-by: Mina Almasry <almasrymina@google•com>
Hi Mina,
I noticed minor issue relating to generated code.
...
> diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
> index cbb544bd6c84..93f4333e7bc6 100644
> --- a/Documentation/netlink/specs/netdev.yaml
> +++ b/Documentation/netlink/specs/netdev.yaml
The lines preceding the hunk below are:
name: napi-set
doc: Set configurable NAPI instance settings.
attribute-set: napi
flags: [ admin-perm ]
do:
request:
attributes:
- id
> @@ -711,6 +711,18 @@ operations:
> - defer-hard-irqs
> - gro-flush-timeout
> - irq-suspend-timeout
> + -
> + name: bind-tx
> + doc: Bind dmabuf to netdev for TX
> + attribute-set: dmabuf
Unlike the entry for napi-set there is no "flags: [ admin-perm ]" fpr
bind-tx...
> + do:
> + request:
> + attributes:
> + - ifindex
> + - fd
> + reply:
> + attributes:
> + - id
>
> kernel-family:
> headers: [ "linux/list.h"]
...
> diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c
...
> @@ -190,6 +196,13 @@ static const struct genl_split_ops netdev_nl_ops[] = {
The lines preceding this hunk are:
{
.cmd = NETDEV_CMD_NAPI_SET,
.doit = netdev_nl_napi_set_doit,
.policy = netdev_napi_set_nl_policy,
> .maxattr = NETDEV_A_NAPI_IRQ_SUSPEND_TIMEOUT,
> .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
> },
> + {
> + .cmd = NETDEV_CMD_BIND_TX,
> + .doit = netdev_nl_bind_tx_doit,
> + .policy = netdev_bind_tx_nl_policy,
> + .maxattr = NETDEV_A_DMABUF_FD,
> + .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
... so I don't think GENL_ADMIN_PERM should be here.
Flagged by running tools/net/ynl/ynl-regen.sh -f && git diff
> + },
> };
>
> static const struct genl_multicast_group netdev_nl_mcgrps[] = {
...
next prev parent reply other threads:[~2025-01-31 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 21:15 [PATCH RFC net-next v2 0/6] Device memory TCP TX Mina Almasry
2025-01-30 21:15 ` [PATCH RFC net-next v2 1/6] net: add devmem TCP TX documentation Mina Almasry
2025-01-30 22:59 ` Stanislav Fomichev
2025-01-30 23:22 ` Mina Almasry
2025-01-31 17:39 ` Stanislav Fomichev
2025-01-30 21:15 ` [PATCH RFC net-next v2 2/6] selftests: ncdevmem: Implement devmem TCP TX Mina Almasry
2025-01-30 23:05 ` Stanislav Fomichev
2025-01-30 23:29 ` Mina Almasry
2025-01-31 17:41 ` Stanislav Fomichev
2025-01-31 17:45 ` Stanislav Fomichev
2025-01-30 21:15 ` [PATCH RFC net-next v2 3/6] net: add get_netmem/put_netmem support Mina Almasry
2025-01-30 21:15 ` [PATCH RFC net-next v2 4/6] net: devmem: TCP tx netlink api Mina Almasry
2025-01-31 8:29 ` Simon Horman [this message]
2025-01-30 21:15 ` [PATCH RFC net-next v2 5/6] net: devmem: Implement TX path Mina Almasry
2025-01-30 23:07 ` Stanislav Fomichev
2025-01-31 9:09 ` Simon Horman
2025-01-30 21:15 ` [PATCH RFC net-next v2 6/6] net: devmem: make dmabuf unbinding scheduled work Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250131082928.GA24105@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=asml.silence@gmail$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=sgarzare@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=stefanha@redhat$(echo .)com \
--cc=victor@mojatatu$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox