Subject: Re: [PATCH ethtool-next 08/14] cmis: Enable JSON output support in CMIS modules

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Feb 2025 12:59:27 -0800

On Sun, 2 Feb 2025 18:22:18 +0000 Danielle Ratson wrote:
>                 "type": "object",
>                 "properties": {
>                         "br_nominal_units": {
>                                 "type": "string",
>                                 "enum": ["Mbps"] },
>                         "length_(smf)_units": {
>                                 "type": "string",
>                                 "enum": ["km"] },
>                         "length_(om5)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },
>                         "length_(om4)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },
>                         "length_(om3)_units": {
>                                 "type": "string",
>                                 "enum": ["m"] },

Hm. I would have expected properties to match the main output.

So:

                 "type": "object",
                 "properties": {
                         "br_nominal": {
                                 "type": "string",
                                 "description": "Nominal bitrate. Unit: Mbps" },
                         "length_(smf)": {
                                 "type": "string",
                                 "description": "Unit: km" },
                         "length_(om5)": {
                                 "type": "string",
                                 "description": "Unit: m" },
                         "length_(om4)": {
                                 "type": "string",
                                 "description": "Unit: m" },
                         "length_(om3)": {
                                 "type": "string",
                                 "description": "Unit: m" },