From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Ming Yu <a0282524688@gmail•com>
Cc: tmyu0@nuvoton•com, lee@kernel•org, linus.walleij@linaro•org,
brgl@bgdev•pl, andi.shyti@kernel•org, mkl@pengutronix•de,
mailhol.vincent@wanadoo•fr, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, wqlinux@roeck-us•net, jdelvare@suse•com,
linux-kernel@vger•kernel.org, linux-gpio@vger•kernel.org,
linux-i2c@vger•kernel.org, linux-can@vger•kernel.org,
netdev@vger•kernel.org, linux-watchdog@vger•kernel.org,
linux-hwmon@vger•kernel.org, linux-rtc@vger•kernel.org,
linux-usb@vger•kernel.org
Subject: Re: [PATCH v6 7/7] rtc: Add Nuvoton NCT6694 RTC support
Date: Wed, 5 Feb 2025 11:23:46 +0100 [thread overview]
Message-ID: <20250205102214a6357365@mail.local> (raw)
In-Reply-To: <20250123091115.2079802-8-a0282524688@gmail.com>
On 23/01/2025 17:11:15+0800, Ming Yu wrote:
> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> + nct6694_irq, IRQF_ONESHOT,
> + "rtc-nct6694", data);
> + if (ret < 0)
> + return dev_err_probe(&pdev->dev, ret, "Failed to request irq\n");
> +
> + ret = devm_rtc_register_device(data->rtc);
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Failed to register rtc\n");
This message is not necessary, all the error paths of
devm_rtc_register_device already print a message
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-02-05 10:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 9:11 [PATCH v6 0/7] Add Nuvoton NCT6694 MFD drivers Ming Yu
2025-01-23 9:11 ` [PATCH v6 1/7] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2025-01-23 9:11 ` [PATCH v6 2/7] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2025-01-23 9:11 ` [PATCH v6 3/7] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2025-01-23 9:11 ` [PATCH v6 4/7] can: Add Nuvoton NCT6694 CANFD support Ming Yu
2025-01-23 11:09 ` Simon Horman
2025-02-04 2:55 ` Ming Yu
2025-01-26 8:47 ` Vincent Mailhol
2025-02-04 3:24 ` Ming Yu
2025-02-06 11:05 ` Vincent Mailhol
2025-01-23 9:11 ` [PATCH v6 5/7] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2025-01-26 10:13 ` Vincent Mailhol
2025-02-04 2:44 ` Ming Yu
2025-01-23 9:11 ` [PATCH v6 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2025-01-26 7:42 ` Vincent Mailhol
2025-01-26 13:18 ` Guenter Roeck
2025-02-04 2:52 ` Ming Yu
2025-01-23 9:11 ` [PATCH v6 7/7] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
2025-02-05 10:23 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205102214a6357365@mail.local \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=a0282524688@gmail$(echo .)com \
--cc=andi.shyti@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=brgl@bgdev$(echo .)pl \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lee@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=tmyu0@nuvoton$(echo .)com \
--cc=wqlinux@roeck-us$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox