* [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool
@ 2025-02-04 21:57 Jakub Kicinski
2025-02-04 21:57 ` [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
2025-02-06 9:40 ` [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Jakub Kicinski @ 2025-02-04 21:57 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski
Michal did an amazing job converting ethtool to Netlink, but never
added an entry to MAINTAINERS for himself. Create a formal entry
so that we can delegate (portions) of this code to folks.
Over the last 3 years majority of the reviews have been done by
Andrew and I. I suppose Michal didn't want to be on the receiving
end of the flood of patches.
Reviewed-by: Simon Horman <horms@kernel•org>
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
MAINTAINERS | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 74b09dad4662..20c8daf3ce62 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16455,6 +16455,16 @@ F: include/net/dsa.h
F: net/dsa/
F: tools/testing/selftests/drivers/net/dsa/
+NETWORKING [ETHTOOL]
+M: Andrew Lunn <andrew@lunn•ch>
+M: Jakub Kicinski <kuba@kernel•org>
+F: Documentation/netlink/specs/ethtool.yaml
+F: Documentation/networking/ethtool-netlink.rst
+F: include/linux/ethtool*
+F: include/uapi/linux/ethtool*
+F: net/ethtool/
+F: tools/testing/selftests/drivers/net/*/ethtool*
+
NETWORKING [GENERAL]
M: "David S. Miller" <davem@davemloft•net>
M: Eric Dumazet <edumazet@google•com>
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry
2025-02-04 21:57 [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool Jakub Kicinski
@ 2025-02-04 21:57 ` Jakub Kicinski
2025-02-05 16:22 ` Simon Horman
2025-02-06 9:40 ` [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2025-02-04 21:57 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, andrew+netdev, horms, Jakub Kicinski
I feel like we don't do a good enough keeping authors of driver
APIs around. The ethtool code base was very nicely compartmentalized
by Michal. Establish a precedent of creating MAINTAINERS entries
for "sections" of the ethtool API. Use Andrew and cable test as
a sample entry. The entry should ideally cover 3 elements:
a core file, test(s), and keywords. The last one is important
because we intend the entries to cover core code *and* reviews
of drivers implementing given API!
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
v2:
- use cable_test as the keyword, looks like it doesn't produce any
false positives
v1: https://lore.kernel.org/20250202021155.1019222-2-kuba@kernel.org
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 20c8daf3ce62..bd705e9123a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16465,6 +16465,12 @@ F: include/uapi/linux/ethtool*
F: net/ethtool/
F: tools/testing/selftests/drivers/net/*/ethtool*
+NETWORKING [ETHTOOL CABLE TEST]
+M: Andrew Lunn <andrew@lunn•ch>
+F: net/ethtool/cabletest.c
+F: tools/testing/selftests/drivers/net/*/ethtool*
+K: cable_test
+
NETWORKING [GENERAL]
M: "David S. Miller" <davem@davemloft•net>
M: Eric Dumazet <edumazet@google•com>
--
2.48.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry
2025-02-04 21:57 ` [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
@ 2025-02-05 16:22 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-02-05 16:22 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, andrew+netdev
On Tue, Feb 04, 2025 at 01:57:50PM -0800, Jakub Kicinski wrote:
> I feel like we don't do a good enough keeping authors of driver
> APIs around. The ethtool code base was very nicely compartmentalized
> by Michal. Establish a precedent of creating MAINTAINERS entries
> for "sections" of the ethtool API. Use Andrew and cable test as
> a sample entry. The entry should ideally cover 3 elements:
> a core file, test(s), and keywords. The last one is important
> because we intend the entries to cover core code *and* reviews
> of drivers implementing given API!
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> v2:
> - use cable_test as the keyword, looks like it doesn't produce any
> false positives
> v1: https://lore.kernel.org/20250202021155.1019222-2-kuba@kernel.org
Reviewed-by: Simon Horman <horms@kernel•org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool
2025-02-04 21:57 [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool Jakub Kicinski
2025-02-04 21:57 ` [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
@ 2025-02-06 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-06 9:40 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, andrew+netdev, horms
Hello:
This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat•com>:
On Tue, 4 Feb 2025 13:57:29 -0800 you wrote:
> Michal did an amazing job converting ethtool to Netlink, but never
> added an entry to MAINTAINERS for himself. Create a formal entry
> so that we can delegate (portions) of this code to folks.
>
> Over the last 3 years majority of the reviews have been done by
> Andrew and I. I suppose Michal didn't want to be on the receiving
> end of the flood of patches.
>
> [...]
Here is the summary with links:
- [net,v2,1/2] MAINTAINERS: add entry for ethtool
https://git.kernel.org/netdev/net/c/1e3835a8aea5
- [net,v2,2/2] MAINTAINERS: add a sample ethtool section entry
https://git.kernel.org/netdev/net/c/82b02a7c4599
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-06 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-04 21:57 [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool Jakub Kicinski
2025-02-04 21:57 ` [PATCH net v2 2/2] MAINTAINERS: add a sample ethtool section entry Jakub Kicinski
2025-02-05 16:22 ` Simon Horman
2025-02-06 9:40 ` [PATCH net v2 1/2] MAINTAINERS: add entry for ethtool patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox