Subject: Re: [PATCH net-next v2 3/3] selftests: drv-net: add a simple TSO test

From: Jakub Kicinski <[email-masked]>
Date: Sat, 15 Feb 2025 08:31:21 -0800

On Sat, 15 Feb 2025 09:49:26 -0500 Willem de Bruijn wrote:
> > +        cases = []
> > +        for outer_ipv4 in [True, False]:
> > +            for info in test_info:
> > +                # Skip if test which only works for a specific IP version
> > +                if outer_ipv4 == info[1]:  
> 
> Only if need to respin:
> 
> using ternary True, False, None for skip_ipv6, skip_ipv4, skip_neither
> is a bit non-obvious. Use strings?

Now that you say it..
I think using ipver with values "4" "6" could clean up a few things.
I'll poke a little bit on Monday, and probably respin.