Subject: Re: [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper

From: Jakub Kicinski <[email-masked]>
Date: Mon, 17 Feb 2025 16:32:56 -0800

On Thu, 13 Feb 2025 04:42:37 -0800 Breno Leitao wrote:
> +static bool dev_comp_addr(struct net_device *dev, unsigned short type,

sorry for the nit, but: dev_comp_addr() -> dev_addr_cmp() ?

cmp is the typical abbreviation for compare in C

> + * dev_getbyhwaddr - find a device by its hardware address

another tiny nit here: I think ideally there should be a () after the
function name
-- 
pw-bot: cr