From: Simon Horman <horms@kernel•org>
To: Piotr Wejman <wejmanpm@gmail•com>
Cc: Tony Nguyen <anthony.l.nguyen@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux•dev>
Subject: Re: [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
Date: Tue, 18 Feb 2025 12:59:59 +0000 [thread overview]
Message-ID: <20250218125959.GS1615191@kernel.org> (raw)
In-Reply-To: <20250216155729.63862-1-wejmanpm@gmail.com>
On Sun, Feb 16, 2025 at 04:57:28PM +0100, Piotr Wejman wrote:
> Update the driver to use the new hardware timestamping API added in commit
> 66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
> Use Netlink extack for error reporting in e1000e_config_hwtstamp.
> Align the indentation of net_device_ops.
>
> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux•dev>
> Signed-off-by: Piotr Wejman <wejmanpm@gmail•com>
Reviewed-by: Simon Horman <horms@kernel•org>
...
> @@ -3932,7 +3939,11 @@ static void e1000e_systim_reset(struct e1000_adapter *adapter)
> spin_unlock_irqrestore(&adapter->systim_lock, flags);
>
> /* restore the previous hwtstamp configuration settings */
> - e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config);
> + ret_val = e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config, &extack);
nit: If there is a v4 for some other reason, please consider line-wrapping
the above to avoid lines that are more than 80 columns wide.
ret_val = e1000e_config_hwtstamp(adapter, &adapter->hwtstamp_config,
&extack);
> + if (ret_val) {
> + if (extack._msg)
> + e_err("%s\n", extack._msg);
> + }
> }
>
> /**
> @@ -6079,8 +6090,8 @@ static int e1000_change_mtu(struct net_device *netdev, int new_mtu)
> return 0;
> }
>
> -static int e1000_mii_ioctl(struct net_device *netdev, struct ifreq *ifr,
> - int cmd)
> +static int e1000_ioctl(struct net_device *netdev, struct ifreq *ifr,
> + int cmd)
nit: And conversely, if there is a v4 for some other reason,
please consider merging the above two lines into one.
...
next prev parent reply other threads:[~2025-02-18 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 15:57 [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Piotr Wejman
2025-02-18 12:59 ` Simon Horman [this message]
2025-02-18 16:01 ` [Intel-wired-lan] " Lifshits, Vitaly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218125959.GS1615191@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=wejmanpm@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox