From: Simon Horman <horms@kernel•org>
To: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
Cc: intel-wired-lan@lists•osuosl.org, netdev@vger•kernel.org,
marcin.szycik@linux•intel.com, jedrzej.jagielski@intel•com,
przemyslaw.kitszel@intel•com, piotr.kwapulinski@intel•com,
anthony.l.nguyen@intel•com, dawid.osuchowski@intel•com,
pmenzel@molgen•mpg.de
Subject: Re: [iwl-next v3 3/4] ixgbe: add Tx hang detection unhandled MDD
Date: Tue, 18 Feb 2025 19:36:46 +0000 [thread overview]
Message-ID: <20250218193646.GJ1615191@kernel.org> (raw)
In-Reply-To: <20250217090636.25113-4-michal.swiatkowski@linux.intel.com>
On Mon, Feb 17, 2025 at 10:06:35AM +0100, Michal Swiatkowski wrote:
> From: Slawomir Mrozowicz <slawomirx.mrozowicz@intel•com>
>
> Add Tx Hang detection due to an unhandled MDD Event.
>
> Previously, a malicious VF could disable the entire port causing
> TX to hang on the E610 card.
> Those events that caused PF to freeze were not detected
> as an MDD event and usually required a Tx Hang watchdog timer
> to catch the suspension, and perform a physical function reset.
>
> Implement flows in the affected PF driver in such a way to check
> the cause of the hang, detect it as an MDD event and log an
> entry of the malicious VF that caused the Hang.
>
> The PF blocks the malicious VF, if it continues to be the source
> of several MDD events.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel•com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux•intel.com>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel•com>
> Co-developed-by: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2025-02-18 19:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 9:06 [iwl-next v3 0/4] ixgbe: support Malicious Driver Detection (MDD) Michal Swiatkowski
2025-02-17 9:06 ` [iwl-next v3 1/4] ixgbe: add MDD support Michal Swiatkowski
2025-02-18 19:36 ` Simon Horman
2025-06-27 9:47 ` [Intel-wired-lan] " Romanowski, Rafal
2025-02-17 9:06 ` [iwl-next v3 2/4] ixgbe: check for MDD events Michal Swiatkowski
2025-02-18 19:36 ` Simon Horman
2025-06-27 9:48 ` [Intel-wired-lan] " Romanowski, Rafal
2025-02-17 9:06 ` [iwl-next v3 3/4] ixgbe: add Tx hang detection unhandled MDD Michal Swiatkowski
2025-02-18 19:36 ` Simon Horman [this message]
2025-06-27 9:49 ` [Intel-wired-lan] " Romanowski, Rafal
2025-02-17 9:06 ` [iwl-next v3 4/4] ixgbe: turn off MDD while modifying SRRCTL Michal Swiatkowski
2025-02-18 19:36 ` Simon Horman
2025-06-27 9:49 ` [Intel-wired-lan] " Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218193646.GJ1615191@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=dawid.osuchowski@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jedrzej.jagielski@intel$(echo .)com \
--cc=marcin.szycik@linux$(echo .)intel.com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=piotr.kwapulinski@intel$(echo .)com \
--cc=pmenzel@molgen$(echo .)mpg.de \
--cc=przemyslaw.kitszel@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox