From: Jakub Kicinski <kuba@kernel•org>
To: Daniel Xu <dxu@dxuuu•xyz>
Cc: Taehee Yoo <ap420073@gmail•com>,
davem@davemloft•net, pabeni@redhat•com, edumazet@google•com,
netdev@vger•kernel.org, almasrymina@google•com,
donald.hunter@gmail•com, corbet@lwn•net,
michael.chan@broadcom•com, andrew+netdev@lunn•ch,
hawk@kernel•org, ilias.apalodimas@linaro•org, ast@kernel•org,
daniel@iogearbox•net, john.fastabend@gmail•com, dw@davidwei•uk,
sdf@fomichev•me, asml.silence@gmail•com, brett.creeley@amd•com,
linux-doc@vger•kernel.org, kory.maincent@bootlin•com,
maxime.chevallier@bootlin•com, danieller@nvidia•com,
hengqi@linux•alibaba.com, ecree.xilinx@gmail•com,
przemyslaw.kitszel@intel•com, hkallweit1@gmail•com,
ahmed.zaki@intel•com, rrameshbabu@nvidia•com, idosch@nvidia•com,
jiri@resnulli•us, bigeasy@linutronix•de, lorenzo@kernel•org,
jdamato@fastly•com, aleksander.lobakin@intel•com,
kaiyuanz@google•com, willemb@google•com, daniel.zahka@gmail•com,
Andy Gospodarek <gospo@broadcom•com>
Subject: Re: [PATCH net-next v9 07/10] bnxt_en: add support for tcp-data-split ethtool command
Date: Wed, 19 Feb 2025 17:07:37 -0800 [thread overview]
Message-ID: <20250219170737.25a3a4ed@kernel.org> (raw)
In-Reply-To: <lq62gh5sua72thbwswtodutom44d77nar2pxo7gue4h3w2muoc@tpol55i7vic5>
On Wed, 19 Feb 2025 10:11:01 -0700 Daniel Xu wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > index f88b641533fc..1bfff7f29310 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
> > @@ -395,6 +395,10 @@ static int bnxt_xdp_set(struct bnxt *bp, struct bpf_prog *prog)
> > bp->dev->mtu, BNXT_MAX_PAGE_MODE_MTU);
> > return -EOPNOTSUPP;
> > }
> > + if (prog && bp->flags & BNXT_FLAG_HDS) {
> > + netdev_warn(dev, "XDP is disallowed when HDS is enabled.\n");
> > + return -EOPNOTSUPP;
> > + }
>
> I think there might be a bug here. On my 6.13 (ish) kernel when I try to
> install an XDP driver mode program, I get:
>
> [Tue Feb 18 17:02:14 2025] bnxt_en 0000:01:00.0 eth0: XDP is disallowed when HDS is enabled.
>
> Setting HDS to auto (seems like off isn't supported?) doesn't seem to
> help either:
This should fix it, I think:
https://lore.kernel.org/20250220005318.560733-1-kuba@kernel.org
next prev parent reply other threads:[~2025-02-20 1:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 14:28 [PATCH net-next v9 0/10] bnxt_en: implement tcp-data-split and thresh option Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 01/10] net: ethtool: add hds_config member in ethtool_netdev_state Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 02/10] net: ethtool: add support for configuring hds-thresh Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 03/10] net: devmem: add ring parameter filtering Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 04/10] net: ethtool: " Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 05/10] net: disallow setup single buffer XDP when tcp-data-split is enabled Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 06/10] bnxt_en: add support for rx-copybreak ethtool command Taehee Yoo
2025-01-15 6:25 ` Michael Chan
2025-01-14 14:28 ` [PATCH net-next v9 07/10] bnxt_en: add support for tcp-data-split " Taehee Yoo
2025-01-15 6:27 ` Michael Chan
2025-02-19 17:11 ` Daniel Xu
2025-02-20 1:07 ` Jakub Kicinski [this message]
2025-01-14 14:28 ` [PATCH net-next v9 08/10] bnxt_en: add support for hds-thresh " Taehee Yoo
2025-01-15 6:28 ` Michael Chan
2025-01-14 14:28 ` [PATCH net-next v9 09/10] netdevsim: add HDS feature Taehee Yoo
2025-01-14 14:28 ` [PATCH net-next v9 10/10] selftest: net-drv: hds: add test for " Taehee Yoo
2025-01-15 23:00 ` [PATCH net-next v9 0/10] bnxt_en: implement tcp-data-split and thresh option patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219170737.25a3a4ed@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=aleksander.lobakin@intel$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ap420073@gmail$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=brett.creeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.zahka@gmail$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=danieller@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=dxu@dxuuu$(echo .)xyz \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gospo@broadcom$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kaiyuanz@google$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=lorenzo@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox