From: Jakub Kicinski <kuba@kernel•org>
To: Joe Damato <jdamato@fastly•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, andrew+netdev@lunn•ch, horms@kernel•org,
stfomichev@gmail•com, petrm@nvidia•com
Subject: Re: [PATCH net-next v2 1/7] selftests: drv-net: add a warning for bkg + shell + terminate
Date: Thu, 20 Feb 2025 13:10:59 -0800 [thread overview]
Message-ID: <20250220131059.66d590e0@kernel.org> (raw)
In-Reply-To: <Z7eDF2lsaQbWl0Yo@LQ3V64L9R2>
On Thu, 20 Feb 2025 14:31:35 -0500 Joe Damato wrote:
> > + if shell and self.terminate:
> > + print("# Warning: combining shell and terminate is risky!")
> > + print("# SIGTERM may not reach the child on zsh/ksh!")
> > +
>
> This warning did not print on my system, FWIW. Up to you if you want
> to respin and drop it or just leave it be.
You mean when running this patchset? It shouldn't, the current
test uses ksft_wait rather than terminate. The warning is for
test developers trying to use the risky config in new tests.
> I am fine with this warning being added, although I disagree with
> the commit message as mentioned in my previous email.
I'll edit the commit message when applying. Unless you want to dig
deeper and find out why your bash/env is different than mine :(
GNU bash, version 5.2.32(1)-release (x86_64-redhat-linux-gnu)
We know that "some shells" fork, that's the important point.
next prev parent reply other threads:[~2025-02-20 21:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 23:49 [PATCH net-next v2 0/7] selftests: drv-net: improve the queue test for XSK Jakub Kicinski
2025-02-19 23:49 ` [PATCH net-next v2 1/7] selftests: drv-net: add a warning for bkg + shell + terminate Jakub Kicinski
2025-02-20 17:27 ` Stanislav Fomichev
2025-02-20 17:48 ` Joe Damato
2025-02-20 19:31 ` Joe Damato
2025-02-20 21:10 ` Jakub Kicinski [this message]
2025-02-20 22:53 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 2/7] selftests: drv-net: use cfg.rpath() in netlink xsk attr test Jakub Kicinski
2025-02-19 23:49 ` [PATCH net-next v2 3/7] selftests: drv-net: add missing new line in xdp_helper Jakub Kicinski
2025-02-20 7:26 ` Kurt Kanzenbach
2025-02-20 17:48 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 4/7] selftests: drv-net: probe for AF_XDP sockets more explicitly Jakub Kicinski
2025-02-20 17:27 ` Stanislav Fomichev
2025-02-20 18:16 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 5/7] selftests: drv-net: add a way to wait for a local process Jakub Kicinski
2025-02-20 17:29 ` Stanislav Fomichev
2025-02-20 19:28 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 6/7] selftests: drv-net: improve the use of ksft helpers in XSK queue test Jakub Kicinski
2025-02-20 7:31 ` Kurt Kanzenbach
2025-02-19 23:49 ` [PATCH net-next v2 7/7] selftests: drv-net: rename queues check_xdp to check_xsk Jakub Kicinski
2025-02-20 19:35 ` [PATCH net-next v2 0/7] selftests: drv-net: improve the queue test for XSK Joe Damato
2025-02-21 2:17 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220131059.66d590e0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=stfomichev@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox