Subject: Re: [PATCH iwl-next v4 1/6] ice: fix check for existing switch rule

From: Simon Horman <[email-masked]>
Date: Thu, 20 Feb 2025 14:55:37 +0000

On Fri, Feb 14, 2025 at 09:50:35AM +0100, Larysa Zaremba wrote:
> From: Mateusz Pacuszka <[email-masked]>
> 
> In case the rule already exists and another VSI wants to subscribe to it
> new VSI list is being created and both VSIs are moved to it.
> Currently, the check for already existing VSI with the same rule is done
> based on fdw_id.hw_vsi_id, which applies only to LOOKUP_RX flag.
> Change it to vsi_handle. This is software VSI ID, but it can be applied
> here, because vsi_map itself is also based on it.
> 
> Additionally change return status in case the VSI already exists in the
> VSI map to "Already exists". Such case should be handled by the caller.

FWIIW, I might have made this two patches, but I don't feel
particularly strongly about it.

> 
> Signed-off-by: Mateusz Pacuszka <[email-masked]>
> Reviewed-by: Przemek Kitszel <[email-masked]>
> Reviewed-by: Michal Swiatkowski <[email-masked]>
> Signed-off-by: Larysa Zaremba <[email-masked]>

Reviewed-by: Simon Horman <[email-masked]>