Subject: Re: [RESEND PATCH] sctp: Replace zero-length array with flexible array member

From: Jakub Kicinski <[email-masked]>
Date: Thu, 20 Feb 2025 17:33:25 -0800

On Wed, 19 Feb 2025 12:26:36 +0100 Thorsten Blum wrote:
> Replace the deprecated zero-length array with a modern flexible array
> member in the struct sctp_idatahdr.
> 
> Link: https://github.com/KSPP/linux/issues/78
> Reviewed-by: Kees Cook <[email-masked]>
> Signed-off-by: Thorsten Blum <[email-masked]>
> ---
>  include/linux/sctp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/sctp.h b/include/linux/sctp.h
> index 836a7e200f39..19eaaf3948ed 100644
> --- a/include/linux/sctp.h
> +++ b/include/linux/sctp.h
> @@ -239,7 +239,7 @@ struct sctp_idatahdr {
>  		__u32 ppid;
>  		__be32 fsn;
>  	};
> -	__u8 payload[0];
> +	__u8 payload[];
>  };
>  
>  struct sctp_idata_chunk {

Builds for me with this field completely delete...
I think we should prefer deleting when possible.
-- 
pw-bot: cr