From: kernel test robot <lkp@intel•com>
To: Chiachang Wang <chiachangwang@google•com>
Cc: oe-kbuild-all@lists•linux.dev, leonro@nvidia•com,
netdev@vger•kernel.org, stanleyjhu@google•com,
steffen.klassert@secunet•com, yumike@google•com
Subject: Re: [PATCH ipsec v2 1/1] xfrm: Migrate offload configuration
Date: Fri, 21 Feb 2025 19:02:44 +0800 [thread overview]
Message-ID: <202502211807.52eely9f-lkp@intel.com> (raw)
In-Reply-To: <20250220073515.3177296-2-chiachangwang@google.com>
Hi Chiachang,
kernel test robot noticed the following build errors:
[auto build test ERROR on klassert-ipsec-next/master]
[also build test ERROR on linus/master v6.14-rc3 next-20250221]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chiachang-Wang/xfrm-Migrate-offload-configuration/20250220-153752
base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
patch link: https://lore.kernel.org/r/20250220073515.3177296-2-chiachangwang%40google.com
patch subject: [PATCH ipsec v2 1/1] xfrm: Migrate offload configuration
config: i386-buildonly-randconfig-004-20250221 (https://download.01.org/0day-ci/archive/20250221/202502211807.52eely9f-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250221/202502211807.52eely9f-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel•com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502211807.52eely9f-lkp@intel.com/
All errors (new ones prefixed by >>):
net/key/af_key.c: In function 'pfkey_migrate':
>> net/key/af_key.c:2632:16: error: too few arguments to function 'xfrm_migrate'
2632 | return xfrm_migrate(&sel, dir, XFRM_POLICY_TYPE_MAIN, m, i,
| ^~~~~~~~~~~~
In file included from net/key/af_key.c:28:
include/net/xfrm.h:1883:5: note: declared here
1883 | int xfrm_migrate(const struct xfrm_selector *sel, u8 dir, u8 type,
| ^~~~~~~~~~~~
vim +/xfrm_migrate +2632 net/key/af_key.c
08de61beab8a21c Shinta Sugimoto 2007-02-08 2546
08de61beab8a21c Shinta Sugimoto 2007-02-08 2547 static int pfkey_migrate(struct sock *sk, struct sk_buff *skb,
4c93fbb0626080d David S. Miller 2011-02-25 2548 const struct sadb_msg *hdr, void * const *ext_hdrs)
08de61beab8a21c Shinta Sugimoto 2007-02-08 2549 {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2550 int i, len, ret, err = -EINVAL;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2551 u8 dir;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2552 struct sadb_address *sa;
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2553 struct sadb_x_kmaddress *kma;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2554 struct sadb_x_policy *pol;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2555 struct sadb_x_ipsecrequest *rq;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2556 struct xfrm_selector sel;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2557 struct xfrm_migrate m[XFRM_MAX_DEPTH];
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2558 struct xfrm_kmaddress k;
8d549c4f5d92d80 Fan Du 2013-11-07 2559 struct net *net = sock_net(sk);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2560
08de61beab8a21c Shinta Sugimoto 2007-02-08 2561 if (!present_and_same_family(ext_hdrs[SADB_EXT_ADDRESS_SRC - 1],
08de61beab8a21c Shinta Sugimoto 2007-02-08 2562 ext_hdrs[SADB_EXT_ADDRESS_DST - 1]) ||
08de61beab8a21c Shinta Sugimoto 2007-02-08 2563 !ext_hdrs[SADB_X_EXT_POLICY - 1]) {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2564 err = -EINVAL;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2565 goto out;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2566 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2567
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2568 kma = ext_hdrs[SADB_X_EXT_KMADDRESS - 1];
08de61beab8a21c Shinta Sugimoto 2007-02-08 2569 pol = ext_hdrs[SADB_X_EXT_POLICY - 1];
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2570
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2571 if (pol->sadb_x_policy_dir >= IPSEC_DIR_MAX) {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2572 err = -EINVAL;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2573 goto out;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2574 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2575
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2576 if (kma) {
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2577 /* convert sadb_x_kmaddress to xfrm_kmaddress */
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2578 k.reserved = kma->sadb_x_kmaddress_reserved;
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2579 ret = parse_sockaddr_pair((struct sockaddr *)(kma + 1),
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2580 8*(kma->sadb_x_kmaddress_len) - sizeof(*kma),
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2581 &k.local, &k.remote, &k.family);
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2582 if (ret < 0) {
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2583 err = ret;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2584 goto out;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2585 }
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 2586 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2587
08de61beab8a21c Shinta Sugimoto 2007-02-08 2588 dir = pol->sadb_x_policy_dir - 1;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2589 memset(&sel, 0, sizeof(sel));
08de61beab8a21c Shinta Sugimoto 2007-02-08 2590
08de61beab8a21c Shinta Sugimoto 2007-02-08 2591 /* set source address info of selector */
08de61beab8a21c Shinta Sugimoto 2007-02-08 2592 sa = ext_hdrs[SADB_EXT_ADDRESS_SRC - 1];
08de61beab8a21c Shinta Sugimoto 2007-02-08 2593 sel.family = pfkey_sadb_addr2xfrm_addr(sa, &sel.saddr);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2594 sel.prefixlen_s = sa->sadb_address_prefixlen;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2595 sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2596 sel.sport = ((struct sockaddr_in *)(sa + 1))->sin_port;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2597 if (sel.sport)
582ee43dad8e411 Al Viro 2007-07-26 2598 sel.sport_mask = htons(0xffff);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2599
08de61beab8a21c Shinta Sugimoto 2007-02-08 2600 /* set destination address info of selector */
47162c0b7e26ef2 Himangi Saraogi 2014-05-30 2601 sa = ext_hdrs[SADB_EXT_ADDRESS_DST - 1];
08de61beab8a21c Shinta Sugimoto 2007-02-08 2602 pfkey_sadb_addr2xfrm_addr(sa, &sel.daddr);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2603 sel.prefixlen_d = sa->sadb_address_prefixlen;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2604 sel.proto = pfkey_proto_to_xfrm(sa->sadb_address_proto);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2605 sel.dport = ((struct sockaddr_in *)(sa + 1))->sin_port;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2606 if (sel.dport)
582ee43dad8e411 Al Viro 2007-07-26 2607 sel.dport_mask = htons(0xffff);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2608
08de61beab8a21c Shinta Sugimoto 2007-02-08 2609 rq = (struct sadb_x_ipsecrequest *)(pol + 1);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2610
08de61beab8a21c Shinta Sugimoto 2007-02-08 2611 /* extract ipsecrequests */
08de61beab8a21c Shinta Sugimoto 2007-02-08 2612 i = 0;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2613 len = pol->sadb_x_policy_len * 8 - sizeof(struct sadb_x_policy);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2614
08de61beab8a21c Shinta Sugimoto 2007-02-08 2615 while (len > 0 && i < XFRM_MAX_DEPTH) {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2616 ret = ipsecrequests_to_migrate(rq, len, &m[i]);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2617 if (ret < 0) {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2618 err = ret;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2619 goto out;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2620 } else {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2621 rq = (struct sadb_x_ipsecrequest *)((u8 *)rq + ret);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2622 len -= ret;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2623 i++;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2624 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2625 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2626
08de61beab8a21c Shinta Sugimoto 2007-02-08 2627 if (!i || len > 0) {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2628 err = -EINVAL;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2629 goto out;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2630 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2631
13c1d18931ebb5c Arnaud Ebalard 2008-10-05 @2632 return xfrm_migrate(&sel, dir, XFRM_POLICY_TYPE_MAIN, m, i,
bd12240337f4352 Sabrina Dubroca 2022-11-24 2633 kma ? &k : NULL, net, NULL, 0, NULL);
08de61beab8a21c Shinta Sugimoto 2007-02-08 2634
08de61beab8a21c Shinta Sugimoto 2007-02-08 2635 out:
08de61beab8a21c Shinta Sugimoto 2007-02-08 2636 return err;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2637 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2638 #else
08de61beab8a21c Shinta Sugimoto 2007-02-08 2639 static int pfkey_migrate(struct sock *sk, struct sk_buff *skb,
7f6daa635c28ed6 Stephen Hemminger 2011-03-01 2640 const struct sadb_msg *hdr, void * const *ext_hdrs)
08de61beab8a21c Shinta Sugimoto 2007-02-08 2641 {
08de61beab8a21c Shinta Sugimoto 2007-02-08 2642 return -ENOPROTOOPT;
08de61beab8a21c Shinta Sugimoto 2007-02-08 2643 }
08de61beab8a21c Shinta Sugimoto 2007-02-08 2644 #endif
08de61beab8a21c Shinta Sugimoto 2007-02-08 2645
08de61beab8a21c Shinta Sugimoto 2007-02-08 2646
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-21 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 12:09 [PATCH ipsec v1 0/2] Update offload configuration with SA Chiachang Wang
2025-01-22 12:09 ` [PATCH ipsec v1 1/2] xfrm: Update offload configuration during SA updates Chiachang Wang
2025-01-22 13:07 ` Leon Romanovsky
2025-01-22 13:08 ` Simon Horman
2025-02-20 7:35 ` [PATCH ipsec v2 0/1] Update offload configuration with SA Chiachang Wang
2025-02-20 7:35 ` [PATCH ipsec v2 1/1] xfrm: Migrate offload configuration Chiachang Wang
2025-02-21 11:02 ` kernel test robot [this message]
2025-02-23 11:21 ` Leon Romanovsky
2025-01-22 12:09 ` [PATCH ipsec v1 2/2] " Chiachang Wang
2025-01-22 13:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502211807.52eely9f-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=chiachangwang@google$(echo .)com \
--cc=leonro@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=stanleyjhu@google$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
--cc=yumike@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox