From: Jakub Kicinski <kuba@kernel•org>
To: Haiyang Zhang <haiyangz@microsoft•com>
Cc: linux-hyperv@vger•kernel.org, netdev@vger•kernel.org,
decui@microsoft•com, stephen@networkplumber•org,
kys@microsoft•com, paulros@microsoft•com, olaf@aepfle•de,
vkuznets@redhat•com, davem@davemloft•net, wei.liu@kernel•org,
edumazet@google•com, pabeni@redhat•com, leon@kernel•org,
longli@microsoft•com, ssengar@linux•microsoft.com,
linux-rdma@vger•kernel.org, daniel@iogearbox•net,
john.fastabend@gmail•com, bpf@vger•kernel.org, ast@kernel•org,
hawk@kernel•org, tglx@linutronix•de,
shradhagupta@linux•microsoft.com, linux-kernel@vger•kernel.org,
stable@vger•kernel.org
Subject: Re: [PATCH net] net: mana: Support holes in device list reply msg
Date: Fri, 7 Mar 2025 19:50:29 -0800 [thread overview]
Message-ID: <20250307195029.1dc74f8e@kernel.org> (raw)
In-Reply-To: <1741211181-6990-1-git-send-email-haiyangz@microsoft.com>
On Wed, 5 Mar 2025 13:46:21 -0800 Haiyang Zhang wrote:
> - for (i = 0; i < max_num_devs; i++) {
> + for (i = 0; i < GDMA_DEV_LIST_SIZE &&
> + found_dev < resp.num_of_devs; i++) {
unfortunate mis-indent here, it blend with the code.
checkpatch is right that it should be aligned with opening bracket
> dev = resp.devs[i];
> dev_type = dev.type;
>
> + /* Skip empty devices */
> + if (dev.as_uint32 == 0)
> + continue;
> +
> + found_dev++;
> + dev_info(gc->dev, "Got devidx:%u, type:%u, instance:%u\n", i,
> + dev.type, dev.instance);
Are you sure you want to print this info message for each device,
each time it's probed? Seems pretty noisy. We generally recommend
printing about _unusual_ things.
next prev parent reply other threads:[~2025-03-08 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 21:46 [PATCH net] net: mana: Support holes in device list reply msg Haiyang Zhang
2025-03-05 23:25 ` Long Li
2025-03-07 10:29 ` Shradha Gupta
2025-03-08 3:50 ` Jakub Kicinski [this message]
2025-03-09 22:01 ` [EXTERNAL] " Haiyang Zhang
2025-03-10 12:11 ` Shradha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307195029.1dc74f8e@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olaf@aepfle$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=stable@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox