From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org, donald.hunter@gmail•com,
jacob.e.keller@intel•com, yuyanghuang@google•com,
sdf@fomichev•me, gnault@redhat•com, nicolas.dichtel@6wind•com,
petrm@nvidia•com, Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next 03/13] netlink: specs: rt-addr: remove the fixed members from attrs
Date: Tue, 8 Apr 2025 17:03:50 -0700 [thread overview]
Message-ID: <20250409000400.492371-4-kuba@kernel.org> (raw)
In-Reply-To: <20250409000400.492371-1-kuba@kernel.org>
The purpose of the attribute list is to list the attributes
which will be included in a given message to shrink the objects
for families with huge attr spaces. Fixed structs are always
present in their entirety so there's no point in listing
their members. Current C codegen doesn't expect them and
tries to look up the names in the attribute space.
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
Documentation/netlink/specs/rt-addr.yaml | 20 +++-----------------
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/Documentation/netlink/specs/rt-addr.yaml b/Documentation/netlink/specs/rt-addr.yaml
index df6b23f06a22..0488ce87506c 100644
--- a/Documentation/netlink/specs/rt-addr.yaml
+++ b/Documentation/netlink/specs/rt-addr.yaml
@@ -133,11 +133,6 @@ protonum: 0
request:
value: 20
attributes: &ifaddr-all
- - ifa-family
- - ifa-flags
- - ifa-prefixlen
- - ifa-scope
- - ifa-index
- address
- label
- local
@@ -150,11 +145,6 @@ protonum: 0
request:
value: 21
attributes:
- - ifa-family
- - ifa-flags
- - ifa-prefixlen
- - ifa-scope
- - ifa-index
- address
- local
-
@@ -164,8 +154,7 @@ protonum: 0
dump:
request:
value: 22
- attributes:
- - ifa-index
+ attributes: []
reply:
value: 20
attributes: *ifaddr-all
@@ -177,9 +166,7 @@ protonum: 0
do:
request:
value: 58
- attributes:
- - ifa-family
- - ifa-index
+ attributes: []
reply:
value: 58
attributes: &mcaddr-attrs
@@ -188,8 +175,7 @@ protonum: 0
dump:
request:
value: 58
- attributes:
- - ifa-family
+ attributes: []
reply:
value: 58
attributes: *mcaddr-attrs
--
2.49.0
next prev parent reply other threads:[~2025-04-09 0:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 0:03 [PATCH net-next 00/13] tools: ynl: c: basic netlink-raw support Jakub Kicinski
2025-04-09 0:03 ` [PATCH net-next 01/13] netlink: specs: rename rtnetlink specs in accordance with family name Jakub Kicinski
2025-04-09 4:49 ` Jacob Keller
2025-04-09 12:15 ` Donald Hunter
2025-04-09 14:15 ` Jakub Kicinski
2025-04-09 14:36 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 02/13] netlink: specs: rt-route: specify fixed-header at operations level Jakub Kicinski
2025-04-09 4:50 ` Jacob Keller
2025-04-09 12:16 ` Donald Hunter
2025-04-09 0:03 ` Jakub Kicinski [this message]
2025-04-09 4:53 ` [PATCH net-next 03/13] netlink: specs: rt-addr: remove the fixed members from attrs Jacob Keller
2025-04-09 4:58 ` Jacob Keller
2025-04-09 12:19 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 04/13] netlink: specs: rt-route: " Jakub Kicinski
2025-04-09 4:58 ` Jacob Keller
2025-04-09 12:20 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 05/13] netlink: specs: rt-addr: add C naming info Jakub Kicinski
2025-04-09 4:54 ` Jacob Keller
2025-04-09 12:21 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 06/13] netlink: specs: rt-route: " Jakub Kicinski
2025-04-09 4:54 ` Jacob Keller
2025-04-09 12:21 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 07/13] tools: ynl: support creating non-genl sockets Jakub Kicinski
2025-04-09 4:56 ` Jacob Keller
2025-04-09 12:25 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 08/13] tools: ynl-gen: don't consider requests with fixed hdr empty Jakub Kicinski
2025-04-09 4:57 ` Jacob Keller
2025-04-09 0:03 ` [PATCH net-next 09/13] tools: ynl: don't use genlmsghdr in classic netlink Jakub Kicinski
2025-04-09 4:59 ` Jacob Keller
2025-04-09 12:26 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 10/13] tools: ynl-gen: consider dump ops without a do "type-consistent" Jakub Kicinski
2025-04-09 5:01 ` Jacob Keller
2025-04-09 12:38 ` Donald Hunter
2025-04-09 13:52 ` Jakub Kicinski
2025-04-09 21:58 ` Jacob Keller
2025-04-09 0:03 ` [PATCH net-next 11/13] tools: ynl-gen: use family c-name in notifications Jakub Kicinski
2025-04-09 5:01 ` Jacob Keller
2025-04-09 12:38 ` Donald Hunter
2025-04-09 0:03 ` [PATCH net-next 12/13] tools: ynl: generate code for rt-addr and add a sample Jakub Kicinski
2025-04-09 5:04 ` Jacob Keller
2025-04-09 15:01 ` Jakub Kicinski
2025-04-09 12:50 ` Donald Hunter
2025-04-09 0:04 ` [PATCH net-next 13/13] tools: ynl: generate code for rt-route " Jakub Kicinski
2025-04-09 5:05 ` Jacob Keller
2025-04-09 12:49 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409000400.492371-4-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gnault@redhat$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=yuyanghuang@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox