From: Jakub Kicinski <kuba@kernel•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat•com>,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next] tc: Return an error if filters try to attach too many actions
Date: Wed, 9 Apr 2025 17:10:16 -0700 [thread overview]
Message-ID: <20250409171016.57d7d4b7@kernel.org> (raw)
In-Reply-To: <Z/aj8D1TRQBC7QtU@pop-os.localdomain>
On Wed, 9 Apr 2025 09:44:32 -0700 Cong Wang wrote:
> > + if (tb[TCA_ACT_MAX_PRIO + 1]) {
> > + NL_SET_ERR_MSG_FMT(extack,
> > + "Only %d actions supported per filter",
> > + TCA_ACT_MAX_PRIO);
> > + return -EINVAL;
>
> I wonder ENOSPC is a better errno than EINVAL here?
I think EINVAL is fine, it's the generic "netlink says no" error code.
The string error should be clear enough.
next prev parent reply other threads:[~2025-04-10 0:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 14:55 [PATCH net-next] tc: Return an error if filters try to attach too many actions Toke Høiland-Jørgensen
2025-04-09 16:44 ` Cong Wang
2025-04-10 0:10 ` Jakub Kicinski [this message]
2025-04-14 21:03 ` Cong Wang
2025-04-14 21:24 ` Jakub Kicinski
2025-04-15 14:46 ` Paolo Abeni
2025-04-16 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409171016.57d7d4b7@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=toke@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox