From: Jakub Kicinski <kuba@kernel•org>
To: Maxime Chevallier <maxime.chevallier@bootlin•com>
Cc: davem@davemloft•net, "Andrew Lunn" <andrew@lunn•ch>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
thomas.petazzoni@bootlin•com,
linux-arm-kernel@lists•infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup•eu>,
"Herve Codina" <herve.codina@bootlin•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Russell King" <linux@armlinux•org.uk>,
"Vladimir Oltean" <vladimir.oltean@nxp•com>,
"Köry Maincent" <kory.maincent@bootlin•com>,
"Oleksij Rempel" <o.rempel@pengutronix•de>,
"Simon Horman" <horms@kernel•org>,
"Romain Gantois" <romain.gantois@bootlin•com>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail•com>
Subject: Re: [PATCH net-next v5 1/4] net: ethtool: Introduce per-PHY DUMP operations
Date: Thu, 10 Apr 2025 17:21:55 -0700 [thread overview]
Message-ID: <20250410172155.3cd854d8@kernel.org> (raw)
In-Reply-To: <20250410123350.174105-2-maxime.chevallier@bootlin.com>
On Thu, 10 Apr 2025 14:33:46 +0200 Maxime Chevallier wrote:
> ethnl commands that target a phy_device need a DUMP implementation that
> will fill the reply for every PHY behind a netdev. We therefore need to
> iterate over the dev->topo to list them.
>
> When multiple PHYs are behind the same netdev, it's also useful to
> perform DUMP with a filter on a given netdev, to get the capability of
> every PHY.
>
> Implement dedicated genl ->start(), ->dumpit() and ->done() operations
> for PHY-targetting command, allowing filtered dumps and using a dump
> context that keep track of the PHY iteration for multi-message dump.
Transient warnings here that the new functions are not used :(
Would it work to squash the 3rd and 4th patches in?
Not ideal but better than having a warning.
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-11 0:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 12:33 [PATCH net-next v5 0/4] net: ethtool: Introduce ethnl dump helpers Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 1/4] net: ethtool: Introduce per-PHY DUMP operations Maxime Chevallier
2025-04-11 0:21 ` Jakub Kicinski [this message]
2025-04-11 7:26 ` Maxime Chevallier
2025-04-12 1:52 ` Jakub Kicinski
2025-04-10 12:33 ` [PATCH net-next v5 2/4] net: ethtool: phy: Convert the PHY_GET command to generic phy dump Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 3/4] net: ethtool: plca: Use per-PHY DUMP operations Maxime Chevallier
2025-04-10 12:33 ` [PATCH net-next v5 4/4] net: ethtool: pse-pd: " Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410172155.3cd854d8@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=herve.codina@bootlin$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=piergiorgio.beruto@gmail$(echo .)com \
--cc=romain.gantois@bootlin$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox