From: Rob Herring <robh@kernel•org>
To: Dimitri Fedrau <dima.fedrau@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
"Fedrau Dimitri (LED)" <Dimitri.Fedrau@liebherr•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Florian Fainelli <f.fainelli@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Add support for changing the MAC termination
Date: Fri, 11 Apr 2025 10:04:48 -0500 [thread overview]
Message-ID: <20250411150448.GA3236749-robh@kernel.org> (raw)
In-Reply-To: <20250408171831.GA4828@debian>
On Tue, Apr 08, 2025 at 07:18:31PM +0200, Dimitri Fedrau wrote:
> On Tue, Apr 08, 2025 at 03:28:32PM +0200, Andrew Lunn wrote:
> > On Tue, Apr 08, 2025 at 01:01:17PM +0000, Fedrau Dimitri (LED) wrote:
> > > -----Ursprüngliche Nachricht-----
> > > Von: Andrew Lunn <andrew@lunn•ch>
> > > Gesendet: Dienstag, 8. April 2025 14:47
> > > An: Fedrau Dimitri (LED) <dimitri.fedrau@liebherr•com>
> > > Cc: Heiner Kallweit <hkallweit1@gmail•com>; Russell King <linux@armlinux•org.uk>; David S. Miller <davem@davemloft•net>; Eric Dumazet <edumazet@google•com>; Jakub Kicinski <kuba@kernel•org>; Paolo Abeni <pabeni@redhat•com>; Rob Herring <robh@kernel•org>; Krzysztof Kozlowski <krzk+dt@kernel•org>; Conor Dooley <conor+dt@kernel•org>; Florian Fainelli <f.fainelli@gmail•com>; netdev@vger•kernel.org; devicetree@vger•kernel.org; linux-kernel@vger•kernel.org; Dimitri Fedrau <dima.fedrau@gmail•com>
> > > Betreff: Re: [PATCH net-next v2 3/3] net: phy: dp83822: Add support for changing the MAC termination
> > >
> > > > > +static const u32 mac_termination[] = {
> > > > > + 99, 91, 84, 78, 73, 69, 65, 61, 58, 55, 53, 50, 48, 46, 44, 43,
> > > >
> > > > Please add this list to the binding.
> > >
> > > Add this list to "ti,dp83822.yaml" ?
> >
> > Yes please. Ideally we want the DT validation tools to pick up invalid
> > values before they reach the kernel.
> >
> Ok, but then I would have to add "mac-termination-ohms" property to
> "ti,dp83822.yaml" as well together with the allowed values ? Ending up in
> some sort of duplication, because the property is already defined in
> "ethernet-phy.yaml". Is this the right way to do it ?
It is not duplication because you are adding constraints. I was thinking
the definition in ethernet-phy.yaml should have some logical limit. Say
200 ohms as termination resistance is typically 10s of ohms.
Seems like a long list to define to me, but if the driver is going to
reject unknown values it makes sense. You could also make the driver
just pick the closest match rather than require an exact match.
Resistance values are nominal anyways.
Rob
next prev parent reply other threads:[~2025-04-11 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 7:45 [PATCH net-next v2 0/3] net: phy: dp83822: Add support for changing the MAC series termination Dimitri Fedrau via B4 Relay
2025-04-08 7:45 ` [PATCH net-next v2 1/3] dt-bindings: net: ethernet-phy: add property mac-termination-ohms Dimitri Fedrau via B4 Relay
2025-04-08 7:45 ` [PATCH net-next v2 2/3] net: phy: Add helper for getting MAC termination resistance Dimitri Fedrau via B4 Relay
2025-04-08 9:51 ` Russell King (Oracle)
2025-04-08 7:45 ` [PATCH net-next v2 3/3] net: phy: dp83822: Add support for changing the MAC termination Dimitri Fedrau via B4 Relay
2025-04-08 9:49 ` Russell King (Oracle)
2025-04-08 12:47 ` Andrew Lunn
2025-04-08 13:01 ` AW: " Fedrau Dimitri (LED)
2025-04-08 13:28 ` Andrew Lunn
2025-04-08 17:18 ` Dimitri Fedrau
2025-04-11 15:04 ` Rob Herring [this message]
2025-04-16 7:47 ` Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411150448.GA3236749-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=Dimitri.Fedrau@liebherr$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dima.fedrau@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox