From: Jakub Kicinski <kuba@kernel•org>
To: Abdun Nihaal <abdun.nihaal@gmail•com>
Cc: Markus Elfring <Markus.Elfring@web•de>,
netdev@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Edward Cree <ecree.xilinx@gmail•com>,
Eric Dumazet <edumazet@google•com>,
Jiawen Wu <jiawenwu@trustnetic•com>,
Mengyuan Lou <mengyuanlou@net-swift•com>,
Paolo Abeni <pabeni@redhat•com>,
Sai Krishna <saikrishnag@marvell•com>,
Simon Horman <horms@kernel•org>
Subject: Re: [PATCH net-next] net: ngbe: fix memory leak in ngbe_probe() error path
Date: Fri, 11 Apr 2025 18:32:12 -0700 [thread overview]
Message-ID: <20250411183212.51b084af@kernel.org> (raw)
In-Reply-To: <pok6kit3b7c7sv34mpvmzulycblqys3ntdrz7oyeofxhtfcht6@xa7iihddqrf5>
On Fri, 11 Apr 2025 10:44:55 +0530 Abdun Nihaal wrote:
> Hello Markus,
>
> On Wed, Apr 09, 2025 at 05:23:39PM +0200, Markus Elfring wrote:
> > How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc1#n145
>
> Thanks for pointing that out. Actually I wasn't sure about which commit
> to add as the Fixes tag, so I left it assuming that the maintainers
> would know better.
>
> I was confused between the following two commits both of which change
> the kfree(wx->mac_table) line.
> - 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")
> - 9607a3e62645 ("net: wangxun: Rename private structure in libwx")
I think:
Fixes: 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")
rss_key gets allocated at that point but never freed. The later patches
just move it around and fix up a little but first broken patch counts.
prev parent reply other threads:[~2025-04-12 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 5:37 [PATCH net-next] net: ngbe: fix memory leak in ngbe_probe() error path Abdun Nihaal
2025-04-09 15:23 ` Markus Elfring
2025-04-11 5:14 ` Abdun Nihaal
2025-04-12 1:32 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411183212.51b084af@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Markus.Elfring@web$(echo .)de \
--cc=abdun.nihaal@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saikrishnag@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox