From: Jakub Kicinski <kuba@kernel•org>
To: Gur Stavi <gur.stavi@huawei•com>
Cc: Fan Gong <gongfan1@huawei•com>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Andrew Lunn <andrew+netdev@lunn•ch>, Lee Trager <lee@trager•us>,
<linux-doc@vger•kernel.org>, Jonathan Corbet <corbet@lwn•net>,
Bjorn Helgaas <helgaas@kernel•org>,
Cai Huoqing <cai.huoqing@linux•dev>, luosifu <luosifu@huawei•com>,
Xin Guo <guoxin09@huawei•com>,
Shen Chenyang <shenchenyang1@hisilicon•com>,
Zhou Shuai <zhoushuai28@huawei•com>, Wu Like <wulike1@huawei•com>,
Shi Jing <shijing34@huawei•com>,
Meny Yossefi <meny.yossefi@huawei•com>,
Suman Ghosh <sumang@marvell•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Joe Damato <jdamato@fastly•com>
Subject: Re: [PATCH net-next v10 1/1] hinic3: module initialization and tx/rx logic
Date: Mon, 14 Apr 2025 18:28:20 -0700 [thread overview]
Message-ID: <20250414182820.370e9feb@kernel.org> (raw)
In-Reply-To: <f74da5b6deceacf4e21cd6fa126e88acd3e8b824.1744286279.git.gur.stavi@huawei.com>
On Thu, 10 Apr 2025 15:15:51 +0300 Gur Stavi wrote:
> + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
> + if (err) {
> + dev_warn(&pdev->dev, "Couldn't set 64-bit DMA mask\n");
> + /* try 32 bit DMA mask if 64 bit fails */
> + err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> + if (err) {
> + dev_err(&pdev->dev, "Failed to set DMA mask\n");
> + goto err_release_regions;
> + }
Please take a look at commit 004464835bfc ("hinic: Remove useless
DMA-32 fallback configuration"). This construct was removed in your
other driver now you're bringing it back.
prev parent reply other threads:[~2025-04-15 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 12:15 [PATCH net-next v10 0/1] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2025-04-10 12:15 ` [PATCH net-next v10 1/1] hinic3: module initialization and tx/rx logic Gur Stavi
2025-04-15 1:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414182820.370e9feb@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=cai.huoqing@linux$(echo .)dev \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gongfan1@huawei$(echo .)com \
--cc=guoxin09@huawei$(echo .)com \
--cc=gur.stavi@huawei$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=jdamato@fastly$(echo .)com \
--cc=lee@trager$(echo .)us \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luosifu@huawei$(echo .)com \
--cc=meny.yossefi@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=shenchenyang1@hisilicon$(echo .)com \
--cc=shijing34@huawei$(echo .)com \
--cc=sumang@marvell$(echo .)com \
--cc=wulike1@huawei$(echo .)com \
--cc=zhoushuai28@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox