From: Jakub Kicinski <kuba@kernel•org>
To: Haiyang Zhang <haiyangz@microsoft•com>
Cc: Erni Sri Satya Vennela <ernis@linux•microsoft.com>,
KY Srinivasan <kys@microsoft•com>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
Dexuan Cui <decui@microsoft•com>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"pabeni@redhat•com" <pabeni@redhat•com>,
Long Li <longli@microsoft•com>,
Konstantin Taranov <kotaranov@microsoft•com>,
"horms@kernel•org" <horms@kernel•org>,
"mhklinux@outlook•com" <mhklinux@outlook•com>,
"pasha.tatashin@soleen•com" <pasha.tatashin@soleen•com>,
"kent.overstreet@linux•dev" <kent.overstreet@linux•dev>,
"brett.creeley@amd•com" <brett.creeley@amd•com>,
"schakrabarti@linux•microsoft.com"
<schakrabarti@linux•microsoft.com>,
"shradhagupta@linux•microsoft.com"
<shradhagupta@linux•microsoft.com>,
"ssengar@linux•microsoft.com" <ssengar@linux•microsoft.com>,
"rosenp@gmail•com" <rosenp@gmail•com>,
Paul Rosswurm <paulros@microsoft•com>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/3] net: mana: Add sched HTB offload support
Date: Wed, 23 Apr 2025 14:57:23 -0700 [thread overview]
Message-ID: <20250423145723.7ff12e1a@kernel.org> (raw)
In-Reply-To: <MN0PR21MB3437359D91F059D83AF929F0CABA2@MN0PR21MB3437.namprd21.prod.outlook.com>
On Wed, 23 Apr 2025 15:27:16 +0000 Haiyang Zhang wrote:
> > > We selected tc-htb for our current use case because we plan to support
> > > multiple speed classes in the future.
> >
> > Which net-shapers also support.
>
> Thanks for pointing that out...
> But for easier usage with existing tc tool for customers, can we still
> use tc-htb offload? Does using tc-htb offload for speed clamping break
> any coding convention or API specs?
The only spec here is that the offloaded version is supposed to look
like the non-offloaded one. I really don't see how you can claim that
static single class HTB is a accurate offload of HTB.
next prev parent reply other threads:[~2025-04-23 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 6:33 [PATCH v2 0/3] net: mana: Add HTB Qdisc offload support Erni Sri Satya Vennela
2025-04-21 6:33 ` [PATCH v2 1/3] net: mana: Add speed support in mana_get_link_ksettings Erni Sri Satya Vennela
2025-04-21 12:36 ` Andrew Lunn
2025-04-21 18:14 ` Erni Sri Satya Vennela
2025-04-21 6:33 ` [PATCH v2 2/3] net: mana: Add sched HTB offload support Erni Sri Satya Vennela
2025-04-22 0:03 ` Jakub Kicinski
2025-04-22 19:48 ` Erni Sri Satya Vennela
2025-04-23 0:18 ` Jakub Kicinski
2025-04-23 15:27 ` [EXTERNAL] " Haiyang Zhang
2025-04-23 21:57 ` Jakub Kicinski [this message]
2025-04-21 6:33 ` [PATCH v2 3/3] net: mana: Handle unsupported HWC commands Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423145723.7ff12e1a@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=brett.creeley@amd$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=ernis@linux$(echo .)microsoft.com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kent.overstreet@linux$(echo .)dev \
--cc=kotaranov@microsoft$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=longli@microsoft$(echo .)com \
--cc=mhklinux@outlook$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=paulros@microsoft$(echo .)com \
--cc=rosenp@gmail$(echo .)com \
--cc=schakrabarti@linux$(echo .)microsoft.com \
--cc=shradhagupta@linux$(echo .)microsoft.com \
--cc=ssengar@linux$(echo .)microsoft.com \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox