From: Jakub Kicinski <kuba@kernel•org>
To: Bui Quang Minh <minhquangbui99@gmail•com>
Cc: virtualization@lists•linux.dev,
"Michael S. Tsirkin" <mst@redhat•com>,
"Jason Wang" <jasowang@redhat•com>,
"Xuan Zhuo" <xuanzhuo@linux•alibaba.com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Alexei Starovoitov" <ast@kernel•org>,
"Daniel Borkmann" <daniel@iogearbox•net>,
"Jesper Dangaard Brouer" <hawk@kernel•org>,
"John Fastabend" <john.fastabend@gmail•com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
bpf@vger•kernel.org
Subject: Re: [PATCH v4 4/4] selftests: net: add a virtio_net deadlock selftest
Date: Wed, 23 Apr 2025 15:23:33 -0700 [thread overview]
Message-ID: <20250423152333.68117196@kernel.org> (raw)
In-Reply-To: <aac402b4-d04c-4d7e-91c8-ab6c20c9a74d@gmail.com>
On Wed, 23 Apr 2025 22:20:41 +0700 Bui Quang Minh wrote:
> I've tried to make the setup_xsk into each test. However, I've an issue
> that the XDP socket destruct waits for an RCU grace period as I see this
> sock's flag SOCK_RCU_FREE is set. So if we start the next test right
> away, we can have the error when setting up XDP socket again because
> previous XDP socket has not unbound the network interface's queue yet. I
> can resolve the issue by putting the sleep(1) after closing the socket
> in xdp_helper:
>
> diff --git a/tools/testing/selftests/net/lib/xdp_helper.c
> b/tools/testing/selftests/net/lib/xdp_helper.c
> index f21536ab95ba..e882bb22877f 100644
> --- a/tools/testing/selftests/net/lib/xdp_helper.c
> +++ b/tools/testing/selftests/net/lib/xdp_helper.c
> @@ -162,5 +162,6 @@ int main(int argc, char **argv)
> */
>
> close(sock_fd);
> + sleep(1);
> return 0;
> }
>
> Do you think it's enough or do you have a better suggestion here?
Interesting :S What errno does the kernel return? EBUSY?
Perhaps we could loop for a second retrying the bind()
if kernel returns EBUSY in case it's just a socket waiting
to be cleaned up?
next prev parent reply other threads:[~2025-04-23 22:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 7:28 [PATCH v4 0/4] virtio-net: disable delayed refill when pausing rx Bui Quang Minh
2025-04-17 7:28 ` [PATCH v4 1/4] " Bui Quang Minh
2025-04-21 3:03 ` Jason Wang
2025-04-17 7:28 ` [PATCH v4 2/4] selftests: net: move xdp_helper to net/lib Bui Quang Minh
2025-04-17 7:28 ` [PATCH v4 3/4] selftests: net: add flag to force zerocopy mode in xdp_helper Bui Quang Minh
2025-04-23 1:34 ` Jakub Kicinski
2025-04-17 7:28 ` [PATCH v4 4/4] selftests: net: add a virtio_net deadlock selftest Bui Quang Minh
2025-04-23 1:41 ` Jakub Kicinski
2025-04-23 15:20 ` Bui Quang Minh
2025-04-23 22:23 ` Jakub Kicinski [this message]
2025-04-24 10:33 ` Bui Quang Minh
2025-04-24 22:07 ` Jakub Kicinski
2025-04-23 1:50 ` [PATCH v4 0/4] virtio-net: disable delayed refill when pausing rx patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423152333.68117196@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=jasowang@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=minhquangbui99@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox