From: Jakub Kicinski <kuba@kernel•org>
To: Parvathi Pudi <parvathi@couthit•com>
Cc: danishanwar@ti•com, rogerq@kernel•org, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org,
nm@ti•com, ssantosh@kernel•org, tony@atomide•com,
richardcochran@gmail•com, glaroque@baylibre•com,
schnelle@linux•ibm.com, m-karicheri2@ti•com,
s.hauer@pengutronix•de, rdunlap@infradead•org,
diogo.ivo@siemens•com, basharath@couthit•com, horms@kernel•org,
jacob.e.keller@intel•com, m-malladi@ti•com,
javier.carrasco.cruz@gmail•com, afd@ti•com, s-anna@ti•com,
linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
pratheesh@ti•com, prajith@ti•com, vigneshr@ti•com,
praneeth@ti•com, srk@ti•com, rogerq@ti•com, krishna@couthit•com,
pmohan@couthit•com, mohan@couthit•com
Subject: Re: [PATCH net-next v6 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver
Date: Thu, 24 Apr 2025 19:17:41 -0700 [thread overview]
Message-ID: <20250424191741.55323f28@kernel.org> (raw)
In-Reply-To: <20250423072356.146726-6-parvathi@couthit.com>
On Wed, 23 Apr 2025 12:53:50 +0530 Parvathi Pudi wrote:
> From: Roger Quadros <rogerq@ti•com>
>
> Changes for enabling ethtool support for the newly added PRU Ethernet
> interfaces. Extends the support for statistics collection from PRU internal
> memory and displays it in the user space. Along with statistics,
> enable/disable of features, configuring link speed etc.are now supported.
>
> The firmware running on PRU maintains statistics in internal data memory.
> When requested ethtool collects all the statistics for the specified
> interface and displays it in the user space.
>
> Makefile is updated to include ethtool support into PRUETH driver.
drivers/net/ethernet/ti/icssm/icssm_prueth.h:229: warning: Function parameter or struct member 'stormprev_counter_bc' not described in 'port_statistics'
drivers/net/ethernet/ti/icssm/icssm_prueth.h:229: warning: Function parameter or struct member 'stormprev_counter_mc' not described in 'port_statistics'
drivers/net/ethernet/ti/icssm/icssm_prueth.h:229: warning: Function parameter or struct member 'stormprev_counter_uc' not described in 'port_statistics'
drivers/net/ethernet/ti/icssm/icssm_prueth.h:229: warning: Function parameter or struct member 'cs_error' not described in 'port_statistics'
drivers/net/ethernet/ti/icssm/icssm_prueth.h:229: warning: Excess struct member 'stormprev_counter' description in 'port_statistics'
> +static const struct {
> + char string[ETH_GSTRING_LEN];
> + u32 offset;
> +} prueth_ethtool_stats[] = {
> + {"txBcast", PRUETH_STAT_OFFSET(tx_bcast)},
> + {"txMcast", PRUETH_STAT_OFFSET(tx_mcast)},
> + {"txUcast", PRUETH_STAT_OFFSET(tx_ucast)},
> + {"txOctets", PRUETH_STAT_OFFSET(tx_octets)},
> + {"rxBcast", PRUETH_STAT_OFFSET(rx_bcast)},
> + {"rxMcast", PRUETH_STAT_OFFSET(rx_mcast)},
> + {"rxUcast", PRUETH_STAT_OFFSET(rx_ucast)},
> + {"rxOctets", PRUETH_STAT_OFFSET(rx_octets)},
> +
> + {"tx64byte", PRUETH_STAT_OFFSET(tx64byte)},
> + {"tx65_127byte", PRUETH_STAT_OFFSET(tx65_127byte)},
> + {"tx128_255byte", PRUETH_STAT_OFFSET(tx128_255byte)},
> + {"tx256_511byte", PRUETH_STAT_OFFSET(tx256_511byte)},
> + {"tx512_1023byte", PRUETH_STAT_OFFSET(tx512_1023byte)},
> + {"tx1024byte", PRUETH_STAT_OFFSET(tx1024byte)},
> + {"rx64byte", PRUETH_STAT_OFFSET(rx64byte)},
> + {"rx65_127byte", PRUETH_STAT_OFFSET(rx65_127byte)},
> + {"rx128_255byte", PRUETH_STAT_OFFSET(rx128_255byte)},
> + {"rx256_511byte", PRUETH_STAT_OFFSET(rx256_511byte)},
> + {"rx512_1023byte", PRUETH_STAT_OFFSET(rx512_1023byte)},
> + {"rx1024byte", PRUETH_STAT_OFFSET(rx1024byte)},
> +
> + {"lateColl", PRUETH_STAT_OFFSET(late_coll)},
> + {"singleColl", PRUETH_STAT_OFFSET(single_coll)},
> + {"multiColl", PRUETH_STAT_OFFSET(multi_coll)},
> + {"excessColl", PRUETH_STAT_OFFSET(excess_coll)},
Do not dump into ethtool -S what's reported via standard stats.
next prev parent reply other threads:[~2025-04-25 2:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 6:06 [PATCH net-next v6 00/11] PRU-ICSSM Ethernet Driver Parvathi Pudi
2025-04-23 6:06 ` [PATCH net-next v6 01/11] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx, AM43xx and AM33xx SOCs Parvathi Pudi
2025-04-25 21:19 ` Rob Herring
2025-04-29 10:11 ` Parvathi Pudi
2025-05-02 20:08 ` ALOK TIWARI
2025-04-23 6:06 ` [PATCH net-next v6 02/11] net: ti: prueth: Adds ICSSM Ethernet driver Parvathi Pudi
2025-04-23 6:06 ` [PATCH net-next v6 03/11] net: ti: prueth: Adds PRUETH HW and SW configuration Parvathi Pudi
2025-04-23 7:23 ` [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection, RX and TX support Parvathi Pudi
2025-04-25 2:13 ` Jakub Kicinski
2025-04-29 10:03 ` Parvathi Pudi
2025-05-03 9:01 ` ALOK TIWARI
2025-04-23 7:23 ` [PATCH net-next v6 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver Parvathi Pudi
2025-04-25 2:17 ` Jakub Kicinski [this message]
2025-04-29 10:06 ` Parvathi Pudi
2025-05-03 9:29 ` ALOK TIWARI
2025-04-23 7:23 ` [PATCH net-next v6 06/11] net: ti: prueth: Adds HW timestamping support for PTP using PRU-ICSS IEP module Parvathi Pudi
2025-04-25 2:16 ` Jakub Kicinski
2025-04-29 10:04 ` Parvathi Pudi
2025-04-23 7:23 ` [PATCH net-next v6 07/11] net: ti: prueth: Adds support for network filters for traffic control supported by PRU-ICSS Parvathi Pudi
2025-05-03 9:26 ` ALOK TIWARI
2025-05-05 13:34 ` Parvathi Pudi
2025-04-23 9:06 ` [PATCH net-next v6 08/11] net: ti: prueth: Adds support for RX interrupt coalescing/pacing Parvathi Pudi
2025-04-23 9:06 ` [PATCH net-next v6 09/11] net: ti: prueth: Adds power management support for PRU-ICSS Parvathi Pudi
2025-04-23 9:06 ` [PATCH net-next v6 10/11] net: ti: prueth: Adds support for PRUETH on AM33x and AM43x SOCs Parvathi Pudi
2025-04-23 9:06 ` [PATCH net-next v6 11/11] net: ti: prueth: Adds PTP OC Support for AM335x and AM437x Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424191741.55323f28@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=afd@ti$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=basharath@couthit$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=diogo.ivo@siemens$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=glaroque@baylibre$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=javier.carrasco.cruz@gmail$(echo .)com \
--cc=krishna@couthit$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m-karicheri2@ti$(echo .)com \
--cc=m-malladi@ti$(echo .)com \
--cc=mohan@couthit$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nm@ti$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=parvathi@couthit$(echo .)com \
--cc=pmohan@couthit$(echo .)com \
--cc=prajith@ti$(echo .)com \
--cc=praneeth@ti$(echo .)com \
--cc=pratheesh@ti$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=richardcochran@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rogerq@kernel$(echo .)org \
--cc=rogerq@ti$(echo .)com \
--cc=s-anna@ti$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=srk@ti$(echo .)com \
--cc=ssantosh@kernel$(echo .)org \
--cc=tony@atomide$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox