From: Philipp Stanner <phasta@kernel•org>
To: Sunil Goutham <sgoutham@marvell•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Geetha sowjanya <gakula@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
hariprasad <hkelam@marvell•com>,
Bharat Bhushan <bbhushan2@marvell•com>,
Taras Chornyi <taras.chornyi@plvision•eu>,
Daniele Venzano <venza@brownhat•org>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
Philipp Stanner <phasta@kernel•org>, Helge Deller <deller@gmx•de>,
Simon Horman <horms@kernel•org>,
Jacob Keller <jacob.e.keller@intel•com>,
Ingo Molnar <mingo@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Al Viro <viro@zeniv•linux.org.uk>,
Shannon Nelson <shannon.nelson@amd•com>,
Sabrina Dubroca <sd@queasysnail•net>
Cc: linux-arm-kernel@lists•infradead.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-parisc@vger•kernel.org
Subject: [PATCH v2 5/8] net: ethernet: sis900: Use pure PCI devres API
Date: Fri, 25 Apr 2025 10:57:38 +0200 [thread overview]
Message-ID: <20250425085740.65304-7-phasta@kernel.org> (raw)
In-Reply-To: <20250425085740.65304-2-phasta@kernel.org>
The currently used function pci_request_regions() is one of the
problematic "hybrid devres" PCI functions, which are sometimes managed
through devres, and sometimes not (depending on whether
pci_enable_device() or pcim_enable_device() has been called before).
The PCI subsystem wants to remove this behavior and, therefore, needs to
port all users to functions that don't have this problem.
Replace pci_request_regions() with pcim_request_all_regions().
Signed-off-by: Philipp Stanner <phasta@kernel•org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel•com>
---
drivers/net/ethernet/sis/sis900.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 332cbd725900..df869f82cae8 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c
@@ -468,7 +468,7 @@ static int sis900_probe(struct pci_dev *pci_dev,
SET_NETDEV_DEV(net_dev, &pci_dev->dev);
/* We do a request_region() to register /proc/ioports info. */
- ret = pci_request_regions(pci_dev, "sis900");
+ ret = pcim_request_all_regions(pci_dev, "sis900");
if (ret)
goto err_out;
--
2.48.1
next prev parent reply other threads:[~2025-04-25 8:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 8:57 [PATCH v2 0/8] Phase out hybrid PCI devres API Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 1/8] net: prestera: Use pure " Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 2/8] net: octeontx2: " Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 3/8] net: tulip: " Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 4/8] net: ethernet: natsemi: " Philipp Stanner
2025-04-25 8:57 ` Philipp Stanner [this message]
2025-04-26 12:39 ` [PATCH v2 5/8] net: ethernet: sis900: " Daniele Venzano
2025-04-25 8:57 ` [PATCH v2 6/8] net: mdio: thunder: " Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 7/8] net: thunder_bgx: " Philipp Stanner
2025-04-25 8:57 ` [PATCH v2 8/8] net: thunder_bgx: Don't disable PCI device manually Philipp Stanner
2025-04-28 23:50 ` [PATCH v2 0/8] Phase out hybrid PCI devres API patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425085740.65304-7-phasta@kernel.org \
--to=phasta@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bbhushan2@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=edumazet@google$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mingo@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sgoutham@marvell$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=taras.chornyi@plvision$(echo .)eu \
--cc=tglx@linutronix$(echo .)de \
--cc=venza@brownhat$(echo .)org \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox