Subject: Re: [PATCH] ipv4: fib: Fix fib_info_hash_alloc() allocation type

From: Simon Horman <[email-masked]>
Date: Mon, 28 Apr 2025 21:01:13 +0100

On Fri, Apr 25, 2025 at 11:05:30PM -0700, Kees Cook wrote:
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
> 
> This was allocating many sizeof(struct hlist_head *) when it actually
> wanted sizeof(struct hlist_head). Luckily these are the same size.
> Adjust the allocation type to match the assignment.
> 
> Signed-off-by: Kees Cook <[email-masked]>

Thanks, your analysis matches my understanding of the code.

Reviewed-by: Simon Horman <[email-masked]>