Subject: Re: [PATCH v2] net: rds: Replace strncpy with strscpy in connection setup

From: Jakub Kicinski <[email-masked]>
Date: Tue, 29 Apr 2025 11:09:19 -0700

On Sun, 27 Apr 2025 00:51:13 +0530 Shankari Anand wrote:
> From: Shankari02 <[email-masked]>

Not your full name, the last From: in the email is what matters.
Maybe try to correct the author of the commit in your git tree.

> This patch replaces strncpy() with strscpy(), which is the preferred, safer
> alternative for bounded string copying in the Linux kernel. strscpy() guarantees
> null-termination as long as the destination buffer is non-zero in size and provides
> a return value to detect truncation.

Please wrap the commit message at 72 chars.

> Padding of the 'transport' field is not necessary because it is treated purely
> as a null-terminated string and is not used for binary comparisons or direct
> memory operations that would rely on padding. Therefore, switching to strscpy()
> is safe and appropriate here.

It's treated as purely null-terminated string? Where exactly
in the code do you see that? Because all I see is a memcpy..