From: Simon Horman <horms@kernel•org>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: Andrew Lunn <andrew@lunn•ch>, Jakub Kicinski <kuba@kernel•org>,
Xin Tian <tianx@yunsilicon•com>,
netdev@vger•kernel.org, leon@kernel•org, andrew+netdev@lunn•ch,
pabeni@redhat•com, edumazet@google•com, davem@davemloft•net,
jeff.johnson@oss•qualcomm.com, przemyslaw.kitszel@intel•com,
weihg@yunsilicon•com, wanry@yunsilicon•com, jacky@yunsilicon•com,
parthiban.veerasooran@microchip•com, masahiroy@kernel•org,
kalesh-anakkur.purayil@broadcom•com, geert+renesas@glider•be
Subject: Re: [PATCH net-next v11 14/14] xsc: add ndo_get_stats64
Date: Fri, 6 Jun 2025 13:59:49 +0100 [thread overview]
Message-ID: <20250606125949.GE120308@horms.kernel.org> (raw)
In-Reply-To: <CAMuHMdUk8G0MdoCA9ZyKDJNRC0pbcR0CpfLzpe347OBALADt0g@mail.gmail.com>
On Thu, Jun 05, 2025 at 08:49:30PM +0200, Geert Uytterhoeven wrote:
> On Thu, 5 Jun 2025 at 16:05, Andrew Lunn <andrew@lunn•ch> wrote:
> > On Thu, Jun 05, 2025 at 06:56:15AM -0700, Jakub Kicinski wrote:
> > > On Thu, 5 Jun 2025 15:39:54 +0200 Geert Uytterhoeven wrote:
> > > > On Thu, 5 Jun 2025 at 15:29, Jakub Kicinski <kuba@kernel•org> wrote:
> > > > > On Thu, 5 Jun 2025 15:25:21 +0800 Xin Tian wrote:
> > > > > > Regarding u64_stats_sync.h helpers:
> > > > > > Since our driver exclusively runs on 64-bit platforms (ARM64 or x86_64)
> > > > > > where u64 accesses are atomic, is it still necessary to use these helpers?
> > > > >
> > > > > alright.
> > > >
> > > > [PATCH 1/14] indeed has:
> > > >
> > > > depends on PCI
> > > > depends on ARM64 || X86_64 || COMPILE_TEST
> > > >
> > > > However, if this device is available on a PCIe expansion card, it
> > > > could be plugged into any system with a PCIe expansion slot?
> > >
> > > I've been trying to fight this fight but people keep pushing back :(
> > > Barely any new PCIe driver comes up without depending on X86_64 and/or
> > > ARM64. Maybe we should write down in the docs that it's okay to depend
> > > on 64b but not okay to depend on specific arches?
> >
> > I agree. I expect in a few years time we will start seeing patches to
> > drivers like this adding RISCV, because RISCV has made it into data
> > center CPUs, where this sort of card makes sense. Its the fact it is
> > 64bit which counts here, not ARM or X86_64.
>
> And perhaps little-endian? ;-)
Yes. My experience is that looking at Sparse warnings can yield many
delights that are lurking. Many well aged by now.
...
next prev parent reply other threads:[~2025-06-06 12:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 10:40 [PATCH net-next v11 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 01/14] xsc: Add xsc driver basic framework Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 02/14] xsc: Enable command queue Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 03/14] xsc: Add hardware setup APIs Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 04/14] xsc: Add qp and cq management Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 05/14] xsc: Add eq and alloc Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 06/14] xsc: Init pci irq Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 07/14] xsc: Init auxiliary device Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 08/14] xsc: Add ethernet interface Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 09/14] xsc: Init net device Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 10/14] xsc: Add eth needed qp and cq apis Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 11/14] xsc: ndo_open and ndo_stop Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 12/14] xsc: Add ndo_start_xmit Xin Tian
2025-04-23 10:39 ` [PATCH net-next v11 13/14] xsc: Add eth reception data path Xin Tian
2025-04-23 10:40 ` [PATCH net-next v11 14/14] xsc: add ndo_get_stats64 Xin Tian
2025-04-25 1:48 ` Jakub Kicinski
2025-06-05 7:25 ` Xin Tian
2025-06-05 13:28 ` Jakub Kicinski
2025-06-05 13:39 ` Geert Uytterhoeven
2025-06-05 13:56 ` Jakub Kicinski
2025-06-05 14:04 ` Andrew Lunn
2025-06-05 18:49 ` Geert Uytterhoeven
2025-06-06 12:59 ` Simon Horman [this message]
2025-06-06 7:24 ` Xin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606125949.GE120308@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=geert@linux-m68k$(echo .)org \
--cc=jacky@yunsilicon$(echo .)com \
--cc=jeff.johnson@oss$(echo .)qualcomm.com \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=masahiroy@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=parthiban.veerasooran@microchip$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=tianx@yunsilicon$(echo .)com \
--cc=wanry@yunsilicon$(echo .)com \
--cc=weihg@yunsilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox