Subject: Re: [PATCH net-next v10 04/11] net: ti: prueth: Adds link detection, RX and TX support.

From: Jakub Kicinski <[email-masked]>
Date: Tue, 8 Jul 2025 18:01:07 -0700

On Wed,  2 Jul 2025 20:47:49 +0530 Parvathi Pudi wrote:
> +			if (emac->port_id) {
> +				regmap_update_bits
> +					(prueth->mii_rt,
> +					 PRUSS_MII_RT_TXCFG1,
> +					 PRUSS_MII_RT_TXCFG_TX_CLK_DELAY_MASK,
> +					 delay);

Instead of breaking the lines up like this you should factor the code
out or find some other way to reduce the indentation.

> +	qid = icssm_prueth_get_tx_queue_id(emac->prueth, skb);
> +	ret = icssm_prueth_tx_enqueue(emac, skb, qid);
> +	if (ret) {
> +		if (ret != -ENOBUFS && netif_msg_tx_err(emac) &&
> +		    net_ratelimit())
> +			netdev_err(ndev, "packet queue failed: %d\n", ret);
> +		goto fail_tx;
> +	}

> +	if (ret == -ENOBUFS) {
> +		ret = NETDEV_TX_BUSY;

Something needs to stop the queue, right? Otherwise the stack will 
send the frame right back to the driver.

> +static inline void icssm_emac_finish_napi(struct prueth_emac *emac,
> +					  struct napi_struct *napi,
> +					  int irq)
> +{
> +	napi_complete(napi);
> +	enable_irq(irq);

This helper has a single caller, just put the two lines of code directly
there. And use napi_complete_done(), please.