[PATCH net-next v3 08/11] netlink: specs: define input-xfrm enum in the spec

public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
	andrew+netdev@lunn•ch, horms@kernel•org, donald.hunter@gmail•com,
	shuah@kernel•org, kory.maincent@bootlin•com,
	maxime.chevallier@bootlin•com, sdf@fomichev•me,
	ecree.xilinx@gmail•com, gal@nvidia•com, jdamato@fastly•com,
	andrew@lunn•ch, Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next v3 08/11] netlink: specs: define input-xfrm enum in the spec
Date: Tue, 15 Jul 2025 17:03:28 -0700	[thread overview]
Message-ID: <20250716000331.1378807-9-kuba@kernel.org> (raw)
In-Reply-To: <20250716000331.1378807-1-kuba@kernel.org>

Help YNL decode the values for input-xfrm by defining
the possible values in the spec. Don't define "no change"
as it's an IOCTL artifact with no use in Netlink.

With this change on mlx5 input-xfrm gets decoded:

 # ynl --family ethtool --dump rss-get
 [{'header': {'dev-index': 2, 'dev-name': 'eth0'},
   'hfunc': 1,
   'hkey': b'V\xa8\xf9\x9 ...',
   'indir': [0, 1, ... ],
   'input-xfrm': {'sym-or-xor'},                         <<<
   'flow-hash': {'ah4': {'ip-dst', 'ip-src'},
                 'ah6': {'ip-dst', 'ip-src'},
                 'esp4': {'ip-dst', 'ip-src'},
                 'esp6': {'ip-dst', 'ip-src'},
                 'ip4': {'ip-dst', 'ip-src'},
                 'ip6': {'ip-dst', 'ip-src'},
                 'tcp4': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
                 'tcp6': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
                 'udp4': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'},
                 'udp6': {'l4-b-0-1', 'ip-dst', 'l4-b-2-3', 'ip-src'}}
 }]

Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
v3:
 - make input xfrm a flags field
v2:
 - adjust the test to decoded values
---
 Documentation/netlink/specs/ethtool.yaml      | 21 +++++++++++++++++++
 .../drivers/net/hw/rss_input_xfrm.py          |  6 +++---
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index aa55fc9068e1..d0a9c4120a19 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -158,6 +158,26 @@ c-version-name: ethtool-genl-version
       -
         name: pse-event-sw-pw-control-error
         doc: PSE faced an error managing the power control from software
+  -
+    name: input-xfrm
+    doc: RSS hash function transformations.
+    type: flags
+    enum-name:
+    name-prefix: rxh-xfrm-
+    header: linux/ethtool.h
+    entries:
+      -
+        name: sym-xor
+        doc: >-
+          XOR the corresponding source and destination fields of each specified
+          protocol. Both copies of the XOR'ed fields are fed into the RSS and
+          RXHASH calculation. Note that this XORing reduces the input set
+          entropy and could be exploited to reduce the RSS queue spread.
+      -
+        name: sym-or-xor
+        doc: >-
+          Similar to SYM_XOR, except that one copy of the XOR'ed fields is
+          replaced by an OR of the same fields.
   -
     name: rxfh-fields
     name-prefix: rxh-
@@ -1621,6 +1641,7 @@ c-version-name: ethtool-genl-version
       -
         name: input-xfrm
         type: u32
+        enum: input-xfrm
       -
         name: start-context
         type: u32
diff --git a/tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py b/tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py
index 648ff50bc1c3..6e90fb290564 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_input_xfrm.py
@@ -37,11 +37,11 @@ from lib.py import rand_port
     if not hasattr(socket, "SO_INCOMING_CPU"):
         raise KsftSkipEx("socket.SO_INCOMING_CPU was added in Python 3.11")
 
-    input_xfrm = cfg.ethnl.rss_get(
-        {'header': {'dev-name': cfg.ifname}}).get('input-xfrm')
+    rss = cfg.ethnl.rss_get({'header': {'dev-name': cfg.ifname}})
+    input_xfrm = set(filter(lambda x: 'sym' in x, rss.get('input-xfrm', {})))
 
     # Check for symmetric xor/or-xor
-    if not input_xfrm or (input_xfrm != 1 and input_xfrm != 2):
+    if not input_xfrm:
         raise KsftSkipEx("Symmetric RSS hash not requested")
 
     cpus = set()
-- 
2.50.1

next prev parent reply	other threads:[~2025-07-16  0:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16  0:03 [PATCH net-next v3 00/11] ethtool: rss: support RSS_SET via Netlink Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 01/11] ethtool: rss: initial RSS_SET (indirection table handling) Jakub Kicinski
2025-07-16  7:30   ` Gal Pressman
2025-07-16  0:03 ` [PATCH net-next v3 02/11] selftests: drv-net: rss_api: factor out checking min queue count Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 03/11] tools: ynl: support packing binary arrays of scalars Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 04/11] selftests: drv-net: rss_api: test setting indirection table via Netlink Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 05/11] ethtool: rss: support setting hfunc " Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 06/11] ethtool: rss: support setting hkey " Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 07/11] selftests: drv-net: rss_api: test setting hashing key " Jakub Kicinski
2025-07-16  0:03 ` Jakub Kicinski [this message]
2025-07-16  7:43   ` [PATCH net-next v3 08/11] netlink: specs: define input-xfrm enum in the spec Gal Pressman
2025-07-16  0:03 ` [PATCH net-next v3 09/11] ethtool: rss: support setting input-xfrm via Netlink Jakub Kicinski
2025-07-16  0:03 ` [PATCH net-next v3 10/11] ethtool: rss: support setting flow hashing fields Jakub Kicinski
2025-07-16  7:28   ` Gal Pressman
2025-07-16  0:03 ` [PATCH net-next v3 11/11] selftests: drv-net: rss_api: test input-xfrm and hash fields Jakub Kicinski
2025-07-17 23:30 ` [PATCH net-next v3 00/11] ethtool: rss: support RSS_SET via Netlink patchwork-bot+netdevbpf

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:aa55fc9068e dfblob:d0a9c4120a1 dfblob:648ff50bc1c
dfblob:6e90fb29056 )
 OR (
bs:"[PATCH net-next v3 08/11] netlink: specs: define input-xfrm enum in the spec" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716000331.1378807-9-kuba@kernel.org \
    --to=kuba@kernel$(echo .)org \
    --cc=andrew+netdev@lunn$(echo .)ch \
    --cc=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=donald.hunter@gmail$(echo .)com \
    --cc=ecree.xilinx@gmail$(echo .)com \
    --cc=edumazet@google$(echo .)com \
    --cc=gal@nvidia$(echo .)com \
    --cc=horms@kernel$(echo .)org \
    --cc=jdamato@fastly$(echo .)com \
    --cc=kory.maincent@bootlin$(echo .)com \
    --cc=maxime.chevallier@bootlin$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=sdf@fomichev$(echo .)me \
    --cc=shuah@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox