From: Jakub Kicinski <kuba@kernel•org>
To: chia-yu.chang@nokia-bell-labs•com
Cc: alok.a.tiwari@oracle•com, pctammela@mojatatu•com,
horms@kernel•org, donald.hunter@gmail•com, xandfury@gmail•com,
netdev@vger•kernel.org, dave.taht@gmail•com, pabeni@redhat•com,
jhs@mojatatu•com, stephen@networkplumber•org,
xiyou.wangcong@gmail•com, jiri@resnulli•us, davem@davemloft•net,
edumazet@google•com, andrew+netdev@lunn•ch, ast@fiberby•net,
liuhangbin@gmail•com, shuah@kernel•org,
linux-kselftest@vger•kernel.org, ij@kernel•org,
ncardwell@google•com, koen.de_schepper@nokia-bell-labs•com,
g.white@cablelabs•com, ingemar.s.johansson@ericsson•com,
mirja.kuehlewind@ericsson•com, cheshire@apple•com,
rs.ietf@gmx•at, Jason_Livingood@comcast•com,
vidhi_goel@apple•com
Subject: Re: [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc
Date: Wed, 16 Jul 2025 16:45:47 -0700 [thread overview]
Message-ID: <20250716164547.6d415024@kernel.org> (raw)
In-Reply-To: <20250713105234.11618-2-chia-yu.chang@nokia-bell-labs.com>
On Sun, 13 Jul 2025 12:52:29 +0200 chia-yu.chang@nokia-bell-labs•com
wrote:
> +/* DUALPI2 */
> +enum tc_dualpi2_drop_overload {
> + TCA_DUALPI2_DROP_OVERLOAD_OVERFLOW = 0,
> + TCA_DUALPI2_DROP_OVERLOAD_DROP = 1,
> + __TCA_DUALPI2_DROP_OVERLOAD_MAX,
> +};
> +#define TCA_DUALPI2_DROP_OVERLOAD_MAX (__TCA_DUALPI2_DROP_OVERLOAD_MAX - 1)
> +
> +enum tc_dualpi2_drop_early {
> + TCA_DUALPI2_DROP_EARLY_DROP_DEQUEUE = 0,
> + TCA_DUALPI2_DROP_EARLY_DROP_ENQUEUE = 1,
> + __TCA_DUALPI2_DROP_EARLY_MAX,
> +};
> +#define TCA_DUALPI2_DROP_EARLY_MAX (__TCA_DUALPI2_DROP_EARLY_MAX - 1)
> +
> +enum tc_dualpi2_ecn_mask {
> + TCA_DUALPI2_ECN_MASK_L4S_ECT = 1,
> + TCA_DUALPI2_ECN_MASK_CLA_ECT = 2,
> + TCA_DUALPI2_ECN_MASK_ANY_ECT = 3,
> + __TCA_DUALPI2_ECN_MASK_MAX,
> +};
> +#define TCA_DUALPI2_ECN_MASK_MAX (__TCA_DUALPI2_ECN_MASK_MAX - 1)
> +
> +enum tc_dualpi2_split_gso {
> + TCA_DUALPI2_SPLIT_GSO_NO_SPLIT_GSO = 0,
> + TCA_DUALPI2_SPLIT_GSO_SPLIT_GSO = 1,
> + __TCA_DUALPI2_SPLIT_GSO_MAX,
> +};
> +#define TCA_DUALPI2_SPLIT_GSO_MAX (__TCA_DUALPI2_SPLIT_GSO_MAX - 1)
Looks like you fixed the type name but not the entry names :(
Once again, TCA_ stands for TC Attribute. These are not attribute IDs
but values. YNL will expect them to be prefixed with TC_DUALPI2,
for example:
static const char * const tc_dualpi2_ecn_mask_strmap[] = {
[TC_DUALPI2_ECN_MASK_L4S_ECT] = "l4s-ect",
[TC_DUALPI2_ECN_MASK_CLA_ECT] = "cla-ect",
[TC_DUALPI2_ECN_MASK_ANY_ECT] = "any-ect",
};
Only the last enum you're adding in this file, which defines the
attributes IDs should use the TCA_ prefix.
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-16 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-13 10:52 [PATCH v23 net-next 0/6] DUALPI2 patch chia-yu.chang
2025-07-13 10:52 ` [PATCH v23 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc chia-yu.chang
2025-07-16 23:45 ` Jakub Kicinski [this message]
2025-07-17 7:16 ` Chia-Yu Chang (Nokia)
2025-07-17 13:38 ` Jakub Kicinski
2025-07-16 23:48 ` Jakub Kicinski
2025-07-17 7:17 ` Chia-Yu Chang (Nokia)
2025-07-13 10:52 ` [PATCH v23 net-next 2/6] sched: Dump configuration and statistics " chia-yu.chang
2025-07-13 10:52 ` [PATCH v23 net-next 3/6] sched: Add enqueue/dequeue " chia-yu.chang
2025-07-13 10:52 ` [PATCH v23 net-next 4/6] selftests/tc-testing: Fix warning and style check on tdc.sh chia-yu.chang
2025-07-13 10:52 ` [PATCH v23 net-next 5/6] selftests/tc-testing: Add selftests for qdisc DualPI2 chia-yu.chang
2025-07-13 10:52 ` [PATCH v23 net-next 6/6] Documentation: netlink: specs: tc: Add DualPI2 specification chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716164547.6d415024@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Jason_Livingood@comcast$(echo .)com \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ast@fiberby$(echo .)net \
--cc=cheshire@apple$(echo .)com \
--cc=chia-yu.chang@nokia-bell-labs$(echo .)com \
--cc=dave.taht@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=g.white@cablelabs$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=ij@kernel$(echo .)org \
--cc=ingemar.s.johansson@ericsson$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=koen.de_schepper@nokia-bell-labs$(echo .)com \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=mirja.kuehlewind@ericsson$(echo .)com \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=rs.ietf@gmx$(echo .)at \
--cc=shuah@kernel$(echo .)org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vidhi_goel@apple$(echo .)com \
--cc=xandfury@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox