public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

* net: phy: Motorcomm YT85xx reset issue
@ 2025-07-16  2:30 练亮斌
  2025-07-17 13:48 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: 练亮斌 @ 2025-07-16  2:30 UTC (permalink / raw)
  To: netdev; +Cc: Frank.Sae

https://github.com/torvalds/linux/blob/155a3c003e555a7300d156a5252c004c392ec6b0/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c.dtsi

https://github.com/torvalds/linux/blob/155a3c003e555a7300d156a5252c004c392ec6b0/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2.dtsi#L140

nanopi-r2c has a stmmac, which uses clock from yt8521s,
`ip link set dev eth0 down; sleep 1; ip link set dev eth0 up` will
trigger a hard reset on yt8521s (`reset-gpios`), but
`motorcomm,clk-out-frequency-hz` is not applied after reset, then
stmmac die:
```
[   46.656359] rk_gmac-dwmac ff540000.ethernet eth0: Register
MEM_TYPE_PAGE_POOL RxQ-0
[   46.730371] rk_gmac-dwmac ff540000.ethernet eth0: PHY [stmmac-0:03]
driver [YT8521 Gigabit Ethernet] (irq=POLL)
[   46.934670] rk_gmac-dwmac ff540000.ethernet: Failed to reset the dma
[   46.935284] rk_gmac-dwmac ff540000.ethernet eth0: stmmac_hw_setup:
DMA engine initialization failed
[   46.936092] rk_gmac-dwmac ff540000.ethernet eth0: __stmmac_open: Hw
setup failed
```

`motorcomm,clk-out-frequency-hz` should be applied in soft_reset or
config_init, not only in probe.

ref https://github.com/openwrt/openwrt/pull/19415

^ permalink raw reply	[flat|nested] 2+ messages in thread

• * Re: net: phy: Motorcomm YT85xx reset issue
    2025-07-16  2:30 net: phy: Motorcomm YT85xx reset issue 练亮斌
  @ 2025-07-17 13:48 ` Jakub Kicinski
    0 siblings, 0 replies; 2+ messages in thread
  From: Jakub Kicinski @ 2025-07-17 13:48 UTC (permalink / raw)
    To: 练亮斌; +Cc: netdev, Frank.Sae
  
  On Wed, 16 Jul 2025 10:30:36 +0800 练亮斌 wrote:
  > nanopi-r2c has a stmmac, which uses clock from yt8521s,
  > `ip link set dev eth0 down; sleep 1; ip link set dev eth0 up` will
  > trigger a hard reset on yt8521s (`reset-gpios`), but
  > `motorcomm,clk-out-frequency-hz` is not applied after reset, then
  > stmmac die:
  
  Is this a regression or you're trying to figure out how to make it work?
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-17 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16  2:30 net: phy: Motorcomm YT85xx reset issue 练亮斌
2025-07-17 13:48 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox