Subject: Re: [PATCH v4 0/9] vsock/virtio: SKB allocation improvements

From: "Michael S. Tsirkin" <[email-masked]>
Date: Thu, 17 Jul 2025 08:35:11 -0400

On Thu, Jul 17, 2025 at 10:01:07AM +0100, Will Deacon wrote:
> Hi all,
> 
> Here is version four of the patches I previously posted here:
> 
>   v1: https://lore.kernel.org/r/[email-masked]
>   v2: https://lore.kernel.org/r/[email-masked]
>   v3: https://lore.kernel.org/r/[email-masked]
> 
> There are only two minor changes since v3:
> 
>   * Use unlikely() in payload length check on the virtio rx path
> 
>   * Add R-b tags from Stefano
> 
> Cheers,
> 
> Will

in my tree now. Let's see how does it go.

> Cc: Keir Fraser <[email-masked]>
> Cc: Steven Moreland <[email-masked]>
> Cc: Frederick Mayle <[email-masked]>
> Cc: Stefan Hajnoczi <[email-masked]>
> Cc: Stefano Garzarella <[email-masked]>
> Cc: "Michael S. Tsirkin" <[email-masked]>
> Cc: Jason Wang <[email-masked]>
> Cc: "Eugenio Pérez" <[email-masked]>
> Cc: [email-masked] 
> Cc: [email-masked] 
> Cc: [email-masked]
> 
> --->8
> 
> Will Deacon (9):
>   vhost/vsock: Avoid allocating arbitrarily-sized SKBs
>   vsock/virtio: Validate length in packet header before skb_put()
>   vsock/virtio: Move length check to callers of
>     virtio_vsock_skb_rx_put()
>   vsock/virtio: Resize receive buffers so that each SKB fits in a 4K
>     page
>   vsock/virtio: Rename virtio_vsock_alloc_skb()
>   vsock/virtio: Move SKB allocation lower-bound check to callers
>   vhost/vsock: Allocate nonlinear SKBs for handling large receive
>     buffers
>   vsock/virtio: Rename virtio_vsock_skb_rx_put()
>   vsock/virtio: Allocate nonlinear SKBs for handling large transmit
>     buffers
> 
>  drivers/vhost/vsock.c                   | 15 ++++----
>  include/linux/virtio_vsock.h            | 46 +++++++++++++++++++------
>  net/vmw_vsock/virtio_transport.c        | 20 ++++++++---
>  net/vmw_vsock/virtio_transport_common.c |  3 +-
>  4 files changed, 60 insertions(+), 24 deletions(-)
> 
> -- 
> 2.50.0.727.gbf7dc18ff4-goog