From: Jakub Kicinski <kuba@kernel•org>
To: Tariq Toukan <tariqt@nvidia•com>
Cc: Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Saeed Mahameed <saeed@kernel•org>, Gal Pressman <gal@nvidia•com>,
"Leon Romanovsky" <leon@kernel•org>,
Saeed Mahameed <saeedm@nvidia•com>,
Mark Bloch <mbloch@nvidia•com>, <netdev@vger•kernel.org>,
<linux-rdma@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
Lama Kayal <lkayal@nvidia•com>
Subject: Re: [PATCH net-next V2 4/6] net/mlx5e: SHAMPO, Cleanup reservation size formula
Date: Thu, 17 Jul 2025 18:52:42 -0700 [thread overview]
Message-ID: <20250717185242.68891d37@kernel.org> (raw)
In-Reply-To: <1752675472-201445-5-git-send-email-tariqt@nvidia.com>
On Wed, 16 Jul 2025 17:17:50 +0300 Tariq Toukan wrote:
> - int rsrv_size = BIT(mlx5e_shampo_get_log_rsrv_size(mdev, params)) *
> - MLX5E_SHAMPO_WQ_BASE_RESRV_SIZE;
> u16 num_strides = BIT(mlx5e_mpwqe_get_log_num_strides(mdev, params, xsk));
> - int pkt_per_rsrv = BIT(mlx5e_shampo_get_log_pkt_per_rsrv(mdev, params));
> + int pkt_per_rsrv = BIT(mlx5e_shampo_get_log_pkt_per_rsrv(params));
> u8 log_stride_sz = mlx5e_mpwqe_get_log_stride_size(mdev, params, xsk);
> int wq_size = BIT(mlx5e_mpwqe_get_log_rq_size(mdev, params, xsk));
> int wqe_size = BIT(log_stride_sz) * num_strides;
> + int rsrv_size = MLX5E_SHAMPO_WQ_RESRV_SIZE;
So you fixed placement of rsrv_size for RCT but the change
to pkt_per_rsrv is still breaking the order :(
I'll pick the first 3 patches up, they look unrelated.
next prev parent reply other threads:[~2025-07-18 1:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 14:17 [PATCH net-next V2 0/6] net/mlx5: misc changes 2025-07-16 Tariq Toukan
2025-07-16 14:17 ` [PATCH net-next V2 1/6] net/mlx5: HWS, Enable IPSec hardware offload in legacy mode Tariq Toukan
2025-07-16 14:17 ` [PATCH net-next V2 2/6] net/mlx5e: fix kdoc warning on eswitch.h Tariq Toukan
2025-07-16 14:17 ` [PATCH net-next V2 3/6] net/mlx5e: Properly access RCU protected qdisc_sleeping variable Tariq Toukan
2025-07-16 14:17 ` [PATCH net-next V2 4/6] net/mlx5e: SHAMPO, Cleanup reservation size formula Tariq Toukan
2025-07-18 1:52 ` Jakub Kicinski [this message]
2025-07-16 14:17 ` [PATCH net-next V2 5/6] net/mlx5e: SHAMPO, Remove mlx5e_shampo_get_log_hd_entry_size() Tariq Toukan
2025-07-16 14:17 ` [PATCH net-next V2 6/6] net/mlx5e: Remove duplicate mkey from SHAMPO header Tariq Toukan
2025-07-18 2:00 ` [PATCH net-next V2 0/6] net/mlx5: misc changes 2025-07-16 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717185242.68891d37@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=lkayal@nvidia$(echo .)com \
--cc=mbloch@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=saeed@kernel$(echo .)org \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox