Subject: Re: [PATCH net-next V2 4/6] net/mlx5e: SHAMPO, Cleanup reservation size formula

From: Jakub Kicinski <[email-masked]>
Date: Thu, 17 Jul 2025 18:52:42 -0700

On Wed, 16 Jul 2025 17:17:50 +0300 Tariq Toukan wrote:
> -	int rsrv_size = BIT(mlx5e_shampo_get_log_rsrv_size(mdev, params)) *
> -		MLX5E_SHAMPO_WQ_BASE_RESRV_SIZE;
>  	u16 num_strides = BIT(mlx5e_mpwqe_get_log_num_strides(mdev, params, xsk));
> -	int pkt_per_rsrv = BIT(mlx5e_shampo_get_log_pkt_per_rsrv(mdev, params));
> +	int pkt_per_rsrv = BIT(mlx5e_shampo_get_log_pkt_per_rsrv(params));
>  	u8 log_stride_sz = mlx5e_mpwqe_get_log_stride_size(mdev, params, xsk);
>  	int wq_size = BIT(mlx5e_mpwqe_get_log_rq_size(mdev, params, xsk));
>  	int wqe_size = BIT(log_stride_sz) * num_strides;
> +	int rsrv_size = MLX5E_SHAMPO_WQ_RESRV_SIZE;

So you fixed placement of rsrv_size for RCT but the change
to pkt_per_rsrv is still breaking the order :(

I'll pick the first 3 patches up, they look unrelated.