From: Simon Horman <horms@kernel•org>
To: Richard Gobert <richardbgobert@gmail•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, dsahern@kernel•org, razor@blackwall•org,
idosch@nvidia•com, petrm@nvidia•com, menglong8.dong@gmail•com,
daniel@iogearbox•net, martin.lau@kernel•org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses
Date: Fri, 18 Jul 2025 08:35:49 +0100 [thread overview]
Message-ID: <20250718073549.GH27043@horms.kernel.org> (raw)
In-Reply-To: <20250717115412.11424-3-richardbgobert@gmail.com>
On Thu, Jul 17, 2025 at 01:54:10PM +0200, Richard Gobert wrote:
...
> @@ -4596,7 +4615,9 @@ static int vxlan_fill_info(struct sk_buff *skb, const struct net_device *dev)
> nla_put_u8(skb, IFLA_VXLAN_REMCSUM_RX,
> !!(vxlan->cfg.flags & VXLAN_F_REMCSUM_RX)) ||
> nla_put_u8(skb, IFLA_VXLAN_LOCALBYPASS,
> - !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)))
> + !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)) ||
> + nla_put_u8(skb, IFLA_VXLAN_LOCALBIND,
> + !!(vxlan->cfg.flags & VXLAN_F_LOCALBIND)))
nit: the indentation of the above two lines seems inconsistent with those
above them - I think it should be a tab and four spaces, rather than
two tabs.
> goto nla_put_failure;
>
> if (nla_put(skb, IFLA_VXLAN_PORT_RANGE, sizeof(ports), &ports))
...
next prev parent reply other threads:[~2025-07-18 7:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 11:54 [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 1/4] net: udp: add freebind option to udp_sock_create Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses Richard Gobert
2025-07-18 7:35 ` Simon Horman [this message]
2025-07-20 14:10 ` Ido Schimmel
2025-07-17 11:54 ` [PATCH net-next v4 3/4] net: vxlan: bind vxlan sockets to their local address Richard Gobert
2025-07-17 11:54 ` [PATCH net-next v4 4/4] net: geneve: enable binding geneve sockets to local addresses Richard Gobert
2025-07-18 7:31 ` Simon Horman
2025-07-18 8:26 ` Simon Horman
2025-07-18 9:00 ` kernel test robot
2025-07-20 14:16 ` Ido Schimmel
2025-07-20 14:00 ` [PATCH net-next v4 0/4] net: add local address bind support to vxlan and geneve Ido Schimmel
2025-07-31 12:05 ` Richard Gobert
2025-07-31 13:07 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718073549.GH27043@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=martin.lau@kernel$(echo .)org \
--cc=menglong8.dong@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=richardbgobert@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox