Subject: Re: [PATCH net-next v4 2/4] net: vxlan: add netlink option to bind vxlan sockets to local addresses

From: Simon Horman <[email-masked]>
Date: Fri, 18 Jul 2025 08:35:49 +0100

On Thu, Jul 17, 2025 at 01:54:10PM +0200, Richard Gobert wrote:

...

> @@ -4596,7 +4615,9 @@ static int vxlan_fill_info(struct sk_buff *skb, const struct net_device *dev)
>  	    nla_put_u8(skb, IFLA_VXLAN_REMCSUM_RX,
>  		       !!(vxlan->cfg.flags & VXLAN_F_REMCSUM_RX)) ||
>  	    nla_put_u8(skb, IFLA_VXLAN_LOCALBYPASS,
> -		       !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)))
> +		       !!(vxlan->cfg.flags & VXLAN_F_LOCALBYPASS)) ||
> +		nla_put_u8(skb, IFLA_VXLAN_LOCALBIND,
> +			   !!(vxlan->cfg.flags & VXLAN_F_LOCALBIND)))

nit: the indentation of the above two lines seems inconsistent with those
     above them - I think it should be a tab and four spaces, rather than
     two tabs.

>  		goto nla_put_failure;
>  
>  	if (nla_put(skb, IFLA_VXLAN_PORT_RANGE, sizeof(ports), &ports))

...